Skip to content

Commit 7f56114

Browse files
committed
[py] Selenium Manager prevents these error messages
1 parent 8472410 commit 7f56114

File tree

8 files changed

+1
-18
lines changed

8 files changed

+1
-18
lines changed

py/selenium/webdriver/chrome/service.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,5 @@ def __init__(
5050
log_path=log_path,
5151
log_output=log_output,
5252
env=env,
53-
start_error_message="Please see https://chromedriver.chromium.org/home",
5453
**kwargs,
5554
)

py/selenium/webdriver/chromium/service.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ def __init__(
4343
log_path: typing.Optional[str] = None,
4444
log_output: SubprocessStdAlias = None,
4545
env: typing.Optional[typing.Mapping[str, str]] = None,
46-
start_error_message: typing.Optional[str] = None,
4746
**kwargs,
4847
) -> None:
4948
self.service_args = service_args or []
@@ -65,7 +64,6 @@ def __init__(
6564
port=port,
6665
env=env,
6766
log_output=self.log_output,
68-
start_error_message=start_error_message,
6967
**kwargs,
7068
)
7169

py/selenium/webdriver/common/service.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ def __init__(
5555
log_file: SubprocessStdAlias = None,
5656
log_output: SubprocessStdAlias = None,
5757
env: typing.Optional[typing.Mapping[typing.Any, typing.Any]] = None,
58-
start_error_message: typing.Optional[str] = None,
5958
**kwargs,
6059
) -> None:
6160
if isinstance(log_output, str):
@@ -73,7 +72,6 @@ def __init__(
7372

7473
self._path = executable
7574
self.port = port or utils.free_port()
76-
self.start_error_message = start_error_message or ""
7775
# Default value for every python subprocess: subprocess.Popen(..., creationflags=0)
7876
self.popen_kw = kwargs.pop("popen_kw", {})
7977
self.creation_flags = self.popen_kw.pop("creation_flags", 0)
@@ -219,16 +217,8 @@ def _start_process(self, path: str) -> None:
219217
except TypeError:
220218
raise
221219
except OSError as err:
222-
if err.errno == errno.ENOENT:
223-
raise WebDriverException(
224-
f"'{os.path.basename(self._path)}' executable needs to be in PATH. {self.start_error_message}"
225-
)
226220
if err.errno == errno.EACCES:
227221
raise WebDriverException(
228222
f"'{os.path.basename(self._path)}' executable may have wrong permissions. {self.start_error_message}"
229223
)
230224
raise
231-
except Exception as e:
232-
raise WebDriverException(
233-
f"The executable {os.path.basename(self._path)} needs to be available in the path. {self.start_error_message}\n{str(e)}"
234-
)

py/selenium/webdriver/edge/service.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,5 @@ def __init__(
6464
log_path=log_path,
6565
log_output=log_output,
6666
env=env,
67-
start_error_message="Please download from https://developer.microsoft.com/en-us/microsoft-edge/tools/webdriver/",
6867
**kwargs,
6968
)

py/selenium/webdriver/firefox/service.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ def __init__(
6565
port=port,
6666
log_output=log_output,
6767
env=env,
68-
start_error_message="Please download the binary from https://github.com/mozilla/geckodriver/releases",
6968
**kwargs,
7069
)
7170

py/selenium/webdriver/ie/service.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,6 @@ def __init__(
6262
executable_path,
6363
port=port,
6464
log_output=log_output,
65-
start_error_message="Please download the binary from https://www.selenium.dev/downloads/ and read up at https://www.selenium.dev/documentation/ie_driver_server/",
6665
**kwargs,
6766
)
6867

py/selenium/webdriver/remote/command.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class Command:
2323
used to marshal commands through a service that implements WebDriver's
2424
remote wire protocol:
2525
26-
https://www.selenium.dev/documentation/legacy/json_wire_protocol/
26+
https://w3c.github.io/webdriver/
2727
"""
2828

2929
# Keep in sync with org.openqa.selenium.remote.DriverCommand

py/selenium/webdriver/safari/service.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ def __init__(
5555
executable=executable_path,
5656
port=port,
5757
env=env,
58-
start_error_message=f"Using Safari built-in binary from {DEFAULT_EXECUTABLE_PATH}",
5958
**kwargs,
6059
)
6160

0 commit comments

Comments
 (0)