Skip to content

Commit 879a5ed

Browse files
Tony HignettAutomatedTester
Tony Hignett
authored and
AutomatedTester
committed
Allow stop to be safely called multiple times.
If stop is called on an already-stopped service (e.g. by __del__) it must not signal the PID of the now-dead phantomjs process. Signed-off-by: AutomatedTester <[email protected]>
1 parent bc8c2c8 commit 879a5ed

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

py/selenium/webdriver/phantomjs/service.py

+1
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ def stop(self):
106106
self.process.stdin.close()
107107
self.process.kill()
108108
self.process.wait()
109+
self.process = None
109110
except OSError:
110111
# kill may not be available under windows environment
111112
pass

0 commit comments

Comments
 (0)