Skip to content

Commit 9d7c2d6

Browse files
committed
Remove deprecated enum constants.
1 parent 54dbe41 commit 9d7c2d6

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

javascript/atoms/error.js

-6
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,8 @@ bot.ErrorCode = {
4646
NO_SUCH_WINDOW: 23,
4747
INVALID_COOKIE_DOMAIN: 24,
4848
UNABLE_TO_SET_COOKIE: 25,
49-
/** @deprecated */
50-
MODAL_DIALOG_OPENED: 26,
5149
UNEXPECTED_ALERT_OPEN: 26,
5250
NO_SUCH_ALERT: 27,
53-
/** @deprecated */
54-
NO_MODAL_DIALOG_OPEN: 27,
5551
SCRIPT_TIMEOUT: 28,
5652
INVALID_ELEMENT_COORDINATES: 29,
5753
IME_NOT_AVAILABLE: 30,
@@ -176,7 +172,6 @@ goog.scope(function() {
176172
map[code.JAVASCRIPT_ERROR] = state.JAVASCRIPT_ERROR;
177173
map[code.METHOD_NOT_ALLOWED] = state.UNSUPPORTED_OPERATION;
178174
map[code.MOVE_TARGET_OUT_OF_BOUNDS] = state.MOVE_TARGET_OUT_OF_BOUNDS;
179-
map[code.NO_MODAL_DIALOG_OPEN] = state.NO_SUCH_ALERT;
180175
map[code.NO_SUCH_ALERT] = state.NO_SUCH_ALERT;
181176
map[code.NO_SUCH_ELEMENT] = state.NO_SUCH_ELEMENT;
182177
map[code.NO_SUCH_FRAME] = state.NO_SUCH_FRAME;
@@ -187,7 +182,6 @@ goog.scope(function() {
187182
map[code.SUCCESS] = state.SUCCESS;
188183
map[code.TIMEOUT] = state.TIMEOUT;
189184
map[code.UNABLE_TO_SET_COOKIE] = state.UNABLE_TO_SET_COOKIE;
190-
map[code.MODAL_DIALOG_OPENED] = state.UNEXPECTED_ALERT_OPEN;
191185
map[code.UNEXPECTED_ALERT_OPEN] = state.UNEXPECTED_ALERT_OPEN
192186
map[code.UNKNOWN_ERROR] = state.UNKNOWN_ERROR;
193187
map[code.UNSUPPORTED_OPERATION] = state.UNKNOWN_COMMAND;

javascript/node/selenium-webdriver/CHANGES.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
## v2.46.0-dev
22

3+
* Removed deprecated enum values: `ErrorCode.NO_MODAL_DIALOG_OPEN` and
4+
`ErrorCode.MODAL_DIALOG_OPENED`. Use `ErrorCode.NO_SUCH_ALERT` and
5+
`ErrorCode.UNEXPECTED_ALERT_OPEN`, respectively.
36
* FIXED: `promise.ControlFlow#wait()` now has consistent semantics for an
47
omitted or 0-timeout: it will wait indefinitely.
58
* FIXED: `remote.DriverService#start()` will now fail if the child process dies
@@ -172,7 +175,7 @@ major version release (i.e. 1.0.0).
172175
* FIXED: 7641: Deprecated `ErrorCode.NO_MODAL_DIALOG_OPEN` and
173176
`ErrorCode.MODAL_DIALOG_OPENED` in favor of the new
174177
`ErrorCode.NO_SUCH_ALERT` and `ErrorCode.UNEXPECTED_ALERT_OPEN`,
175-
respecitvely.
178+
respectively.
176179
* FIXED: 7563: Mocha integration no longer disables timeouts. Default Mocha
177180
timeouts apply (2000 ms) and may be changed using `this.timeout(ms)`.
178181
* FIXED: 7470: Make it easier to create WebDriver instances in custom flows for

0 commit comments

Comments
 (0)