Skip to content

Commit aa4a41e

Browse files
harsha509pujagani
andauthored
[JS]: Handle optional dependency for @bazel/runfiles (#14352)
* [JS]: Handle optional dependency for @bazel/runfiles * fix lint issue * [js]: remove console msg and safe exit if runfiles never found * [js]: fix rbe build(use global node process) * [JS]:Fix error handling for missing runfiles --------- Co-authored-by: Puja Jagani <[email protected]>
1 parent d118949 commit aa4a41e

File tree

1 file changed

+12
-1
lines changed
  • javascript/node/selenium-webdriver/testing

1 file changed

+12
-1
lines changed

javascript/node/selenium-webdriver/testing/index.js

+12-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
const fs = require('node:fs')
3636
const path = require('node:path')
3737
const { isatty } = require('node:tty')
38-
const { runfiles } = require('@bazel/runfiles')
3938
const chrome = require('../chrome')
4039
const edge = require('../edge')
4140
const firefox = require('../firefox')
@@ -46,6 +45,14 @@ const { Browser } = require('../lib/capabilities')
4645
const { Builder } = require('../index')
4746
const { getBinaryPaths } = require('../common/driverFinder')
4847

48+
let runfiles
49+
try {
50+
// Attempt to require @bazel/runfiles
51+
runfiles = require('@bazel/runfiles').runfiles
52+
} catch {
53+
// Fall through
54+
}
55+
4956
/**
5057
* Describes a browser targeted by a {@linkplain suite test suite}.
5158
* @record
@@ -544,6 +551,10 @@ function locate(fileLike) {
544551
return fileLike
545552
}
546553

554+
if (!runfiles) {
555+
throw new Error('Unable to find ' + fileLike)
556+
}
557+
547558
try {
548559
return runfiles.resolve(fileLike)
549560
} catch {

0 commit comments

Comments
 (0)