Skip to content

Commit b66ebd1

Browse files
committed
[rb] guard tests for chrome bug on alerts with bidi
1 parent 97a1769 commit b66ebd1

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

Diff for: rb/spec/integration/selenium/webdriver/bidi/browsing_context_spec.rb

+8-3
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,9 @@ class BiDi
8181
expect(driver.execute_script('return window.devicePixelRatio')).to eq(2.0)
8282
end
8383

84-
it 'accepts users prompts without text' do
84+
it 'accepts users prompts without text',
85+
except: {browser: %i[edge chrome],
86+
reason: 'https://github.com/GoogleChromeLabs/chromium-bidi/issues/3281'} do
8587
browsing_context = described_class.new(bridge)
8688

8789
driver.navigate.to url_for('alerts.html')
@@ -94,7 +96,9 @@ class BiDi
9496
expect(driver.title).to eq('Testing Alerts')
9597
end
9698

97-
it 'accepts users prompts with text' do
99+
it 'accepts users prompts with text',
100+
except: {browser: %i[edge chrome],
101+
reason: 'https://github.com/GoogleChromeLabs/chromium-bidi/issues/3281'} do
98102
browsing_context = described_class.new(bridge)
99103
driver.navigate.to url_for('alerts.html')
100104
driver.find_element(id: 'prompt').click
@@ -106,7 +110,8 @@ class BiDi
106110
expect(driver.title).to eq('Testing Alerts')
107111
end
108112

109-
it 'rejects users prompts' do
113+
it 'rejects users prompts', except: {browser: %i[edge chrome],
114+
reason: 'https://github.com/GoogleChromeLabs/chromium-bidi/issues/3281'} do
110115
browsing_context = described_class.new(bridge)
111116
driver.navigate.to url_for('alerts.html')
112117
driver.find_element(id: 'alert').click

Diff for: rb/spec/integration/selenium/webdriver/fedcm_spec.rb

+4-3
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@
2222
module Selenium
2323
module WebDriver
2424
module FedCM
25-
describe FedCM, exclusive: [{ bidi: false, reason: 'Not yet implemented with BiDi' }, { browser: %i[chrome edge] }] do
25+
describe FedCM,
26+
exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {browser: %i[chrome edge]}] do
2627
let(:dialog) { driver.fedcm_dialog }
2728

2829
before { driver.get url_for('fedcm/fedcm.html') }
@@ -66,8 +67,8 @@ module FedCM
6667
expect(dialog.select_account(1)).to be_nil
6768
end
6869

69-
it 'clicks the dialog', except: { browser: %i[chrome edge],
70-
reason: "error: 'Use another account' not supported for this IDP" } do
70+
it 'clicks the dialog', except: {browser: %i[chrome edge],
71+
reason: "error: 'Use another account' not supported for this IDP"} do
7172
expect(dialog.click).to be_nil
7273
end
7374

0 commit comments

Comments
 (0)