Merge branch 'trunk' into add_missing_events

Author: titusfortner

.bazelrc

@@ -47,20 +47,26 @@ build --test_output=errors
 
 # pass environment variables to the test environment
 
-build --test_env=CI
-build --test_env=DASHBOARD_URL
-build --test_env=DISPLAY
-build --test_env=FIREFOX_NIGHTLY_BINARY
-build --test_env=GITHUB_ACTIONS
-build --test_env=MOZ_HEADLESS
-build --test_env=PATH  # Remove once browser pinning works
-build --test_env=SELENIUM_BROWSER
-build --test_env=TRAVIS
-build --test_env=PYTHON_VERSION
+test --test_env=CI
+test --test_env=DASHBOARD_URL
+test --test_env=DISPLAY
+test --test_env=FIREFOX_NIGHTLY_BINARY
+test --test_env=GITHUB_ACTIONS
+test --test_env=MOZ_HEADLESS
+test --test_env=PATH  # Remove once browser pinning works
+test --test_env=SELENIUM_BROWSER
+test --test_env=TRAVIS
+test --test_env=PYTHON_VERSION
 
 # Remove once rules_ruby support proper $LOAD_PATH expansion.
 
-build --test_env=RUBYOPT="-Irb/lib -w"
+test --test_env=RUBYOPT="-Irb/lib -w"
+
+# Speed up JRuby startup.
+# https://github.com/jruby/jruby/wiki/Improving-startup-time
+
+build --action_env=JRUBY_OPTS="--dev"
+test --test_env=JRUBY_OPTS="--dev"
 
 # JRuby/TruffleRuby: https://github.com/jruby/jruby/issues/5661
 
@@ -76,7 +82,7 @@ test:windows --test_env=PROGRAMFILES(X86)="C:\\Program Files (x86)"
 test --test_timeout=1800
 
 test:node_debug --test_output=streamed --test_strategy=exclusive --test_timeout=9999 --nocache_test_results
-test:ruby_debug --test_output=streamed --test_env=RUBY_DEBUG_FORK_MODE=parent --run_under="@bundle//:bin/rdbg --nonstop --open --command"
+test:ruby_debug --test_output=streamed --test_env=RUBY_DEBUG_FORK_MODE=parent --run_under="@bundle//bin:rdbg --nonstop --open --command"
 
 # The RBE to use
 build:remote --bes_results_url=https://gypsum.cluster.engflow.com/invocation
@@ -113,12 +119,14 @@ build:remote --disk_cache=
 build:remote --incompatible_enable_cc_toolchain_resolution
 build:remote --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
 test:remote --test_env=DISPLAY=:99.0
-test:remote --test_tag_filters=-edge,-safari,-remote
+test:remote --test_tag_filters=-skip-remote,-remote
 
 # Env vars we can hard code
 build:remote --action_env=HOME=/home/dev
 build:remote --action_env=PATH=/bin:/usr/bin:/usr/local/bin
+test:remote --test_env=PATH=/bin:/usr/bin:/usr/local/bin
 test:remote --test_env=HOME=/home/dev
+test --test_env=SE_AVOID_STATS=true
 
 # Make sure we sniff credentials properly
 build:remote --credential_helper=%workspace%/scripts/credential-helper.sh
@@ -146,3 +154,7 @@ build:remote-ci --bes_upload_mode=wait_for_upload_complete
 # Configuration changes suggested by EngFlow
 build:remote --grpc_keepalive_time=30s
 build:remote --nolegacy_important_outputs
+
+build:release --config=remote
+build:release --stamp
+build:release --remote_download_outputs=toplevel

.github/label-commenter-config.yml

@@ -129,3 +129,11 @@ labels:
           This issue is looking for contributors.
 
           Please comment below or reach out to us through our [IRC/Slack/Matrix channels](https://www.selenium.dev/support/) if you are interested.
+  - name: I-logging
+    labeled:
+      issue:
+        body: |
+          We need more information about this issue in order to troubleshoot.
+
+          Please turn on logging and re-run your code. Information on how to adjust logs for your language can be found in our
+          [Troubleshooting documentation](https://www.selenium.dev/documentation/webdriver/troubleshooting/logging/).

.github/workflows/bazel.yml

@@ -55,6 +55,7 @@ jobs:
       GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       SEL_M2_USER: ${{ secrets.SEL_M2_USER }}
       SEL_M2_PASS: ${{ secrets.SEL_M2_PASS }}
+      SE_AVOID_STATS: true
     steps:
       - name: Checkout source tree
         uses: actions/checkout@v4
@@ -70,36 +71,37 @@ jobs:
       - name: Remove driver directories Non-Windows
         if: inputs.os != 'windows'
         run: |
-          sudo rm -rf $CHROMEWEBDRIVER $EDGEWEBDRIVER $GECKOWEBDRIVER
+          sudo rm -rf "$CHROMEWEBDRIVER" "$EDGEWEBDRIVER" "$GECKOWEBDRIVER"
       - name: Set Ruby version
         if: inputs.ruby-version != ''
-        run: echo 'RUBY_VERSION = "${{ inputs.ruby-version }}"' > rb/ruby_version.bzl
+        run: echo '${{ inputs.ruby-version }}' > rb/.ruby-version
       - name: Setup Java
         if: inputs.java-version != ''
         uses: actions/setup-java@v3
         with:
           java-version: ${{ inputs.java-version }}
           distribution: 'temurin'
       - name: Setup Bazel
-        uses: p0deje/setup-bazel@0.2.0
+        uses: p0deje/setup-bazel@0.4.0
         with:
           bazelisk-cache: true
+          bazelrc: common --color=yes
           disk-cache: ${{ inputs.cache-key }}
           external-cache: |
             name: ${{ inputs.cache-key }}
             manifest:
               crates: rust/Cargo.Bazel.lock
               npm: package-lock.json
               pypi__pip: py/requirements_lock.txt
-              rules_ruby_dist: rb/ruby_version.bzl
+              ruby: ${{ inputs.os == 'windows' && 'false' || 'rb/.ruby-version' }}
           repository-cache: true
       - name: Setup Fluxbox and Xvfb
         if: inputs.os == 'ubuntu' && inputs.browser != ''
         run: |
           sudo apt-get -y install fluxbox
           Xvfb :99 &
           fluxbox -display :99 &
-          echo "DISPLAY=:99" >> $GITHUB_ENV
+          echo "DISPLAY=:99" >> "$GITHUB_ENV"
       - name: Set resolution
         if: inputs.os == 'windows' && inputs.browser != ''
         run: Set-DisplayResolution -Width 1920 -Height 1080 -Force

.github/workflows/build-selenium-manager.yml

@@ -12,9 +12,7 @@ jobs:
       name: Build
       cache-key: false
       os: windows
-      run: |
-        bazel build //dotnet/src/webdriver --stamp
-        bazel build //dotnet/src/support --stamp
+      run: bazel build //dotnet:all
 
   integration-tests:
     name: Browser Tests
@@ -25,4 +23,4 @@ jobs:
       java-version: 17
       os: windows
       run: |
-        bazel test //dotnet/test/common:ElementFindingTest-firefox //dotnet/test/common:ElementFindingTest-chrome --pin_browsers=true --stamp
+        bazel test //dotnet/test/common:ElementFindingTest-firefox //dotnet/test/common:ElementFindingTest-chrome --pin_browsers=true

.github/workflows/ci-dotnet.yml

@@ -12,21 +12,6 @@ jobs:
       name: Build
       cache-key: javascript-build
       run: bazel build //javascript/node/selenium-webdriver:selenium-webdriver
-
-  atoms:
-    name: Atom Tests
-    needs: build
-    uses: ./.github/workflows/bazel.yml
-    with:
-      name: Atom Tests
-      browser: firefox
-      cache-key: atoms
-      run: >
-        bazel test --test_tag_filters=firefox,-firefox-beta,-firefox-dev
-        //javascript/atoms/...
-        //javascript/selenium-atoms/...
-        //javascript/webdriver/...
-
   browser-tests:
     name: Browser Tests
     needs: build
@@ -57,7 +42,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 18
       - name: NPM install
         run: cd javascript/grid-ui && npm install
       - name: Run unit tests

.github/workflows/ci-javascript.yml

@@ -77,22 +77,6 @@ jobs:
         env:
           TOXENV: mypy
 
-  browser-tests:
-    name: Browser Tests
-    needs: build
-    uses: ./.github/workflows/bazel.yml
-    strategy:
-      fail-fast: false
-      matrix:
-        browser:
-          - chrome
-          - firefox
-    with:
-      name: Integration Tests (${{ matrix.browser }})
-      browser: ${{ matrix.browser }}
-      cache-key: py-${{ matrix.browser }}
-      run: bazel test --flaky_test_attempts 3 //py:test-${{ matrix.browser }}
-
   remote-tests:
     name: Remote Tests
     needs: build

.github/workflows/ci-python.yml

@@ -10,18 +10,21 @@ on:
 jobs:
   format:
     name: Format
+    if: github.repository_owner == 'seleniumhq'
     uses: ./.github/workflows/bazel.yml
     with:
       name: Check format script run
       cache-key: rbe
-      ruby-version: jruby-9.4.2.0
+      ruby-version: jruby-9.4.5.0
       run: ./scripts/github-actions/check-format.sh
+
   test:
     name: Test
+    if: github.repository_owner == 'seleniumhq'
     uses: ./.github/workflows/bazel.yml
     with:
       # TODO: experiment with turning off caches
       name: All RBE tests
       cache-key: rbe
-      ruby-version: jruby-9.4.2.0
+      ruby-version: jruby-9.4.5.0
       run: ./scripts/github-actions/ci-build.sh

.github/workflows/ci-rbe.yml

@@ -43,13 +43,13 @@ jobs:
             os: ubuntu
           - ruby-version: 3.0.6
             os: windows
-          - ruby-version: 3.2.0
-            os: ubuntu
-          - ruby-version: 3.2.0
+          - ruby-version: 3.0.6
             os: macos
-          - ruby-version: jruby-9.4.3.0
+          - ruby-version: 3.3.0
+            os: ubuntu
+          - ruby-version: jruby-9.4.5.0
             os: ubuntu
-          - ruby-version: truffleruby-22.3.0
+          - ruby-version: truffleruby-23.1.1
             os: ubuntu
     with:
       name: Unit Tests (${{ matrix.ruby-version }}, ${{ matrix.os }})