Skip to content

Commit dd789f2

Browse files
authoredApr 3, 2025··
[java] enable safari for CookieImplementationTest (#15544)
* [java] enable safari for CookieImplementationTest
1 parent d0a851f commit dd789f2

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed
 

‎java/test/org/openqa/selenium/CookieImplementationTest.java

-20
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
import org.openqa.selenium.testing.JupiterTestBase;
3939
import org.openqa.selenium.testing.NeedsSecureServer;
4040
import org.openqa.selenium.testing.NotWorkingInRemoteBazelBuilds;
41-
import org.openqa.selenium.testing.NotYetImplemented;
4241
import org.openqa.selenium.testing.SwitchToTopAfterTest;
4342

4443
@NeedsSecureServer
@@ -74,7 +73,6 @@ public void setUp() {
7473
}
7574

7675
@Test
77-
@NotYetImplemented(SAFARI)
7876
public void testShouldGetCookieByName() {
7977
String key = generateUniqueKey();
8078
String value = "set";
@@ -87,7 +85,6 @@ public void testShouldGetCookieByName() {
8785
}
8886

8987
@Test
90-
@NotYetImplemented(SAFARI)
9188
@NotWorkingInRemoteBazelBuilds(FIREFOX)
9289
public void testShouldBeAbleToAddCookie() {
9390
String key = generateUniqueKey();
@@ -104,7 +101,6 @@ public void testShouldBeAbleToAddCookie() {
104101
}
105102

106103
@Test
107-
@NotYetImplemented(SAFARI)
108104
public void testGetAllCookies() {
109105
String key1 = generateUniqueKey();
110106
String key2 = generateUniqueKey();
@@ -130,7 +126,6 @@ public void testGetAllCookies() {
130126
}
131127

132128
@Test
133-
@NotYetImplemented(SAFARI)
134129
public void testDeleteAllCookies() {
135130
addCookieOnServerSide(new Cookie("foo", "set"));
136131
assertSomeCookiesArePresent();
@@ -144,7 +139,6 @@ public void testDeleteAllCookies() {
144139
}
145140

146141
@Test
147-
@NotYetImplemented(SAFARI)
148142
public void testDeleteCookieWithName() {
149143
String key1 = generateUniqueKey();
150144
String key2 = generateUniqueKey();
@@ -166,7 +160,6 @@ public void testDeleteCookieWithName() {
166160
}
167161

168162
@Test
169-
@NotYetImplemented(SAFARI)
170163
public void testShouldNotDeleteCookiesWithASimilarName() {
171164
String cookieOneName = "fish";
172165
Cookie cookie1 = new Cookie.Builder(cookieOneName, "cod").build();
@@ -187,7 +180,6 @@ public void testShouldNotDeleteCookiesWithASimilarName() {
187180
}
188181

189182
@Test
190-
@NotYetImplemented(SAFARI)
191183
public void testAddCookiesWithDifferentPathsThatAreRelatedToOurs() {
192184
driver.get(domainHelper.getUrlForFirstValidHostname("/common/animals"));
193185
Cookie cookie1 = new Cookie.Builder("fish", "cod").path("/common/animals").build();
@@ -224,7 +216,6 @@ public void testGetCookiesInAFrame() {
224216
}
225217

226218
@Test
227-
@NotYetImplemented(SAFARI)
228219
public void testCannotGetCookiesWithPathDifferingOnlyInCase() {
229220
String cookieName = "fish";
230221
Cookie cookie = new Cookie.Builder(cookieName, "cod").path("/Common/animals").build();
@@ -235,7 +226,6 @@ public void testCannotGetCookiesWithPathDifferingOnlyInCase() {
235226
}
236227

237228
@Test
238-
@NotYetImplemented(SAFARI)
239229
public void testShouldNotGetCookieOnDifferentDomain() {
240230
assumeTrue(domainHelper.checkHasValidAlternateHostname());
241231

@@ -249,7 +239,6 @@ public void testShouldNotGetCookieOnDifferentDomain() {
249239
}
250240

251241
@Test
252-
@NotYetImplemented(SAFARI)
253242
@NotWorkingInRemoteBazelBuilds(FIREFOX)
254243
public void testShouldBeAbleToAddToADomainWhichIsRelatedToTheCurrentDomain() {
255244
String cookieName = "name";
@@ -289,7 +278,6 @@ void testShouldBeAbleToIncludeLeadingPeriodInDomainName() {
289278
}
290279

291280
@Test
292-
@NotYetImplemented(SAFARI)
293281
@NotWorkingInRemoteBazelBuilds(FIREFOX)
294282
public void testShouldBeAbleToSetDomainToTheCurrentDomain() throws Exception {
295283
URI url = new URI(driver.getCurrentUrl());
@@ -304,7 +292,6 @@ public void testShouldBeAbleToSetDomainToTheCurrentDomain() throws Exception {
304292
}
305293

306294
@Test
307-
@NotYetImplemented(SAFARI)
308295
@NotWorkingInRemoteBazelBuilds(CHROME)
309296
@NotWorkingInRemoteBazelBuilds(EDGE)
310297
@NotWorkingInRemoteBazelBuilds(FIREFOX)
@@ -336,7 +323,6 @@ public void testShouldWalkThePathToDeleteACookie() {
336323
}
337324

338325
@Test
339-
@NotYetImplemented(SAFARI)
340326
@NotWorkingInRemoteBazelBuilds(FIREFOX)
341327
public void testShouldIgnoreThePortNumberOfTheHostWhenSettingTheCookie() throws Exception {
342328
URI uri = new URI(driver.getCurrentUrl());
@@ -352,7 +338,6 @@ public void testShouldIgnoreThePortNumberOfTheHostWhenSettingTheCookie() throws
352338
}
353339

354340
@Test
355-
@NotYetImplemented(SAFARI)
356341
@NotWorkingInRemoteBazelBuilds(CHROME)
357342
@NotWorkingInRemoteBazelBuilds(EDGE)
358343
@NotWorkingInRemoteBazelBuilds(FIREFOX)
@@ -383,7 +368,6 @@ public void testCookieEqualityAfterSetAndGet() {
383368
}
384369

385370
@Test
386-
@NotYetImplemented(SAFARI)
387371
public void testRetainsCookieExpiry() {
388372
Cookie addedCookie =
389373
new Cookie.Builder("fish", "cod")
@@ -470,7 +454,6 @@ public void testRetainsHttpOnlyFlag() {
470454
}
471455

472456
@Test
473-
@NotYetImplemented(SAFARI)
474457
public void testSettingACookieThatExpiredInThePast() {
475458
long expires = System.currentTimeMillis() - 1000;
476459
Cookie cookie = new Cookie.Builder("expired", "yes").expiresOn(new Date(expires)).build();
@@ -483,7 +466,6 @@ public void testSettingACookieThatExpiredInThePast() {
483466
}
484467

485468
@Test
486-
@NotYetImplemented(SAFARI)
487469
public void testCanSetCookieWithoutOptionalFieldsSet() {
488470
String key = generateUniqueKey();
489471
String value = "foo";
@@ -496,7 +478,6 @@ public void testCanSetCookieWithoutOptionalFieldsSet() {
496478
}
497479

498480
@Test
499-
@NotYetImplemented(SAFARI)
500481
public void testDeleteNotExistedCookie() {
501482
String key = generateUniqueKey();
502483
assertCookieIsNotPresentWithName(key);
@@ -637,7 +618,6 @@ private void addCookieOnServerSide(Cookie cookie) {
637618
}
638619

639620
@Test
640-
@NotYetImplemented(SAFARI)
641621
public void deleteAllCookies() {
642622
assumeTrue(domainHelper.checkHasValidAlternateHostname());
643623

0 commit comments

Comments
 (0)
Please sign in to comment.