Skip to content

Commit e1d6bbb

Browse files
committed
[java] Use BuildInfo class to get current Selenium version
1 parent d6be6e3 commit e1d6bbb

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

Diff for: java/src/org/openqa/selenium/manager/SeleniumManager.java

+8-6
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import java.util.logging.Logger;
3232

3333
import org.openqa.selenium.Beta;
34+
import org.openqa.selenium.BuildInfo;
3435
import org.openqa.selenium.Capabilities;
3536
import org.openqa.selenium.MutableCapabilities;
3637
import org.openqa.selenium.Platform;
@@ -58,28 +59,29 @@ public class SeleniumManager {
5859
private static final Logger LOG = Logger.getLogger(SeleniumManager.class.getName());
5960

6061

61-
// IMPORTANT: This version needs to be synchronized before each release.
62-
// Alternatively, we can try to use Bazel to automate this task
63-
private static final String SELENIUM_MANAGER_VERSION = "0.4.12";
64-
6562
private static final String SELENIUM_MANAGER = "selenium-manager";
6663
private static final String DEFAULT_CACHE_PATH = "~/.cache/selenium";
6764
private static final String BINARY_PATH_FORMAT = "/manager/%s/%s";
6865
private static final String HOME = "~";
6966
private static final String CACHE_PATH_ENV = "SE_CACHE_PATH";
67+
private static final String BETA_PREFIX = "0.";
7068

7169
private static final String EXE = ".exe";
7270
private static final String INFO = "INFO";
7371
private static final String WARN = "WARN";
7472
private static final String DEBUG = "DEBUG";
7573

7674
private static volatile SeleniumManager manager;
77-
7875
private final String managerPath = System.getenv("SE_MANAGER_PATH");
7976
private Path binary = managerPath == null ? null : Paths.get(managerPath);
77+
private String seleniumManagerVersion;
8078

8179
/** Wrapper for the Selenium Manager binary. */
8280
private SeleniumManager() {
81+
BuildInfo info = new BuildInfo();
82+
String releaseLabel = info.getReleaseLabel();
83+
int lastDot = releaseLabel.lastIndexOf(".");
84+
seleniumManagerVersion = BETA_PREFIX + releaseLabel.substring(0, lastDot);
8385
}
8486

8587
public static SeleniumManager getInstance() {
@@ -297,6 +299,6 @@ private Path getBinaryInCache(String binaryName) {
297299
cachePath = cachePathEnv;
298300
}
299301

300-
return Paths.get(cachePath + String.format(BINARY_PATH_FORMAT, SELENIUM_MANAGER_VERSION, binaryName));
302+
return Paths.get(cachePath + String.format(BINARY_PATH_FORMAT, seleniumManagerVersion, binaryName));
301303
}
302304
}

0 commit comments

Comments
 (0)