You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have a number of engineers who have chromedriver managed by Homebrew. When Chrome updates, they need to keep up-to-date with the latest chromedriver. Currently selenium-webdriver will download the right version of chromedriver ONLY if the Homebrew version is NOT installed.
Uninstalling the Homebrew version doesn't seem like it should be necessary. We would much prefer if selenium-webdriver would download and use the right version of chromedriver if the version in PATH isn't compatible.
One possible fix would be to drop the Platform.find_binary call here:
@stanhu, thank you for creating this issue. We will troubleshoot it as soon as we can.
Info for maintainers
Triage this issue by using labels.
If information is missing, add a helpful comment and then I-issue-template label.
If the issue is a question, add the I-question label.
If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable G-* label, and it will provide the correct link and auto-close the
issue.
After troubleshooting the issue, please add the R-awaiting answer label.
Yes, this matches where we are planning to go. We're tracking this already, elsewhere. Here is an explanation of where we are, and the steps for where we want to go: #11356 (comment)
There are a few complications we need to handle that make this non-trivial:
We want Selenium Manager to be entirely "opt-in" right now, which means if you are doing anything to manage drivers yourself, SM won't try to do it for you
If we do decide to do automatic fixes for users, we'll need to provide a way for them to completely opt-out from using SM (no downloading ever)
Also, users can intentionally use an old version of the driver by passing in a specific argument to the driver, so we'll need to parse that and pass it in as a flag to SM somehow as to whether to fix or use the outdated driver
Feature and motivation
We have a number of engineers who have
chromedriver
managed by Homebrew. When Chrome updates, they need to keep up-to-date with the latestchromedriver
. Currentlyselenium-webdriver
will download the right version ofchromedriver
ONLY if the Homebrew version is NOT installed.Uninstalling the Homebrew version doesn't seem like it should be necessary. We would much prefer if
selenium-webdriver
would download and use the right version ofchromedriver
if the version inPATH
isn't compatible.One possible fix would be to drop the
Platform.find_binary
call here:selenium/rb/lib/selenium/webdriver/common/driver_finder.rb
Lines 26 to 29 in d530584
As far as I understand,
selenium-manager
already looks in thePATH
:selenium/rust/src/lib.rs
Line 318 in b579892
Usage example
This would allow the Homebrew version of
chromedriver
to coexist with the version managed byselenium-webdriver
.The text was updated successfully, but these errors were encountered: