-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Bazel Build tehnical issue #12102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@nvborisenko, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
Thanks for opening this as an issue Until/unless we make a post or article about it, let's use this as a place to explain and document our reasoning. |
I asked Nikolay to create this issue so we can have a single place to direct people or mark as duplicates suggestions to move away from Bazel. My primary concern with using Bazel has been the higher-than-otherwise barrier to entry for encouraging developers to work on our project. That said, there are many advantages to having everything in one system, including addressing many inefficiencies. Personally, I was much more frustrated last year when we had significant deficits (especially in Windows and .NET) and no work was being done on improving it. Very fortunately, super smart people have done a lot of really great work to improve things (thank you!). Our CI build & test times are low and getting lower because of Bazel caching, it is easier to work on all bindings at once than it would be otherwise, and we've managed to automate more things multi-platform in one go. So, while there are legitimate concerns with using Bazel, and while there are valid alternatives, the project as a whole has decided that the benefits of Bazel outweigh the downsides, especially as we make more progress on the initiatives already underway. Simon wrote a great explainer here: |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What happened?
Why not just
dotnet build
, ordotnet pack
, ordotnet test
. It is easy. Solution: keep preconditions for building as artifacts (couple of js files, cdp auto-generated classes). That's all what is required to make dev experience in .net absolutely comfortable.Keeping generated pre-requisites under git allows to:
third_party/dotnet/**
(nuget.exe
is there, hmmm)How I see new process: all bindings (most likely) require common prerequisites. CI process tracks original source, and generate artifacts once original source has been changed - and pushes to repo, which initiates testing stage for all dependent bindings.
Final remark for everybody here: you can remove
*.csproj
files, they are not a part of building process. Ah, CI usesdotnet test
cli command (interesting why not bazel). Hm, andselenium-manager.exe
(pre-requisite) is under git. Philosophy is not kept up.Continuation of #10465
How can we reproduce the issue?
Relevant log output
Operating System
any
Selenium version
any dotnet, selenium 4.0+
What are the browser(s) and version(s) where you see this issue?
any
What are the browser driver(s) and version(s) where you see this issue?
any
Are you using Selenium Grid?
No response
The text was updated successfully, but these errors were encountered: