Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: [dotnet] [bidi] Rework ContinueWithAuth method #15539

Closed
nvborisenko opened this issue Mar 31, 2025 · 1 comment · Fixed by #15545
Closed

[🚀 Feature]: [dotnet] [bidi] Rework ContinueWithAuth method #15539

nvborisenko opened this issue Mar 31, 2025 · 1 comment · Fixed by #15545
Labels
C-dotnet .NET Bindings I-enhancement Something could be better

Comments

@nvborisenko
Copy link
Member

Feature and motivation

BiDi spec: https://w3c.github.io/webdriver-bidi/#command-network-continueWithAuth

network.ContinueWithAuth = (
  method: "network.continueWithAuth",
  params: network.ContinueWithAuthParameters
)

network.ContinueWithAuthParameters = {
  request: network.Request,
  (network.ContinueWithAuthCredentials // network.ContinueWithAuthNoCredentials)
}

network.ContinueWithAuthCredentials = (
  action: "provideCredentials", 
  credentials: network.AuthCredentials
)

network.ContinueWithAuthNoCredentials = (
  action: "default" / "cancel"
)

We can apply method overload here! The example is: #15533. It is good interpretation of CDDL to .NET.

Usage example

User will call one method ContinueWithAuthAsync(...) as spec defines it, but with options how to proceed further.

@nvborisenko nvborisenko added I-enhancement Something could be better C-dotnet .NET Bindings labels Mar 31, 2025
@nvborisenko
Copy link
Member Author

New pattern determined:

network.ContinueWithAuthParameters = {
request: network.Request,
(network.ContinueWithAuthCredentials // network.ContinueWithAuthNoCredentials)
}

Meaning in .NET world it is method overload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-dotnet .NET Bindings I-enhancement Something could be better
Projects
None yet
1 participant