You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ideally all *EventArgs should be immutable. But from spec perspective, it is just a type, even regular type, which can be mutable. If we really want to make all event args immutable, then we should create a copy of class (including all referenced classed). I don't think we really want to do it.
Another option is to accept that event args can be mutable (no effect for users). But then name all event args as spec defines them (without EventArgs prefix). It also makes sense to convert EventArgs class to IEventArgs interface, because if spec with defines inheritance, we cannot support it.
Usage example
Just types renaming.
The text was updated successfully, but these errors were encountered:
Feature and motivation
https://github.com/SeleniumHQ/selenium/blob/trunk/dotnet/src/webdriver/BiDi/EventArgs.cs
Ideally all
*EventArgs
should be immutable. But from spec perspective, it is just a type, even regular type, which can be mutable. If we really want to make all event args immutable, then we should create a copy of class (including all referenced classed). I don't think we really want to do it.Another option is to accept that event args can be mutable (no effect for users). But then name all event args as spec defines them (without
EventArgs
prefix). It also makes sense to convertEventArgs
class toIEventArgs
interface, because if spec with defines inheritance, we cannot support it.Usage example
Just types renaming.
The text was updated successfully, but these errors were encountered: