Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: [dotnet] [bidi] Re-think about EventArgs #15546

Open
nvborisenko opened this issue Apr 1, 2025 · 0 comments
Open

[🚀 Feature]: [dotnet] [bidi] Re-think about EventArgs #15546

nvborisenko opened this issue Apr 1, 2025 · 0 comments
Labels
C-dotnet .NET Bindings I-enhancement Something could be better

Comments

@nvborisenko
Copy link
Member

Feature and motivation

https://github.com/SeleniumHQ/selenium/blob/trunk/dotnet/src/webdriver/BiDi/EventArgs.cs

Ideally all *EventArgs should be immutable. But from spec perspective, it is just a type, even regular type, which can be mutable. If we really want to make all event args immutable, then we should create a copy of class (including all referenced classed). I don't think we really want to do it.

Another option is to accept that event args can be mutable (no effect for users). But then name all event args as spec defines them (without EventArgs prefix). It also makes sense to convert EventArgs class to IEventArgs interface, because if spec with defines inheritance, we cannot support it.

Usage example

Just types renaming.

@nvborisenko nvborisenko added I-enhancement Something could be better C-dotnet .NET Bindings labels Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-dotnet .NET Bindings I-enhancement Something could be better
Projects
None yet
Development

No branches or pull requests

1 participant