Skip to content

[🚀 Feature]: [dotnet] [bidi] Reevaluate nullable parameters in DTO constructors #15561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nvborisenko opened this issue Apr 3, 2025 · 1 comment
Labels
B-devtools Includes everything BiDi or Chrome DevTools related C-dotnet .NET Bindings I-enhancement Something could be better

Comments

@nvborisenko
Copy link
Member

nvborisenko commented Apr 3, 2025

Description

Example:

browsingContext.Info = {
  children: browsingContext.InfoList / null,
  clientWindow: browser.ClientWindow,
  ? parent: browsingContext.BrowsingContext / null,
}

In .net it should be:

public record BrowsingContextInfo(IReadOnlyList<BrowsingContextInfo>? Children, Browser.ClientWindow ClientWindow)
{
    [JsonInclude]
    public BrowsingContext? Parent { get; internal set; }
}

So, children prop is in ctor (as for now), BUT it should be nullable because of browsingContext.InfoList / null. This is only about it: review all / null entries in spec and make appropriate type as nullable.

Have you considered any alternatives or workarounds?

No response

@nvborisenko nvborisenko added A-needs-triaging A Selenium member will evaluate this soon! I-enhancement Something could be better labels Apr 3, 2025
@titusfortner
Copy link
Member

@nvborisenko, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then J-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@github-actions github-actions bot added B-devtools Includes everything BiDi or Chrome DevTools related C-dotnet .NET Bindings labels Apr 3, 2025
@nvborisenko nvborisenko removed the A-needs-triaging A Selenium member will evaluate this soon! label Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-devtools Includes everything BiDi or Chrome DevTools related C-dotnet .NET Bindings I-enhancement Something could be better
Projects
None yet
Development

No branches or pull requests

2 participants