-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[🐛 Bug]: [py] FedCM dialog not opening #15581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@cgoldberg, thank you for creating this issue. We will troubleshoot it as soon as we can. Selenium Triage Team: remember to follow the Triage Guide |
Hi @cgoldberg, I see that the tests pass fine in macOS. In Linux, I was able to use FedCM functionality but Bazel was having some issues with all the tests (was getting the
This is not the right way to use the FedCM functionality, FedCM has some dependencies. For quickly testing out FedCM, you can start a HTTP server in this dir - https://github.com/SeleniumHQ/selenium/tree/trunk/common/src/web/fedcm using Now you can test FedCM related functionality by pointing your tests to from selenium import webdriver
import time
driver = webdriver.Chrome()
driver.get("http://localhost:8000/fedcm.html")
driver.execute_script("triggerFedCm();"). # this needs to be called for fedcm_dialog() to work
dialog = driver.fedcm_dialog()
time.sleep(1)
driver.quit() Using the above script you can see that the FedCM dialog box is visible. I am not sure why only those 2 tests are failing in the CI for Linux only, other tests also use the exact same pattern for calling the FedCM dialog box and they pass. I tried increasing the timeout to 10 here but it still fails! |
@navin772 thanks for the information... I will try using FedCM locally using your instructions and report back with the results. FWIW, I get that same |
@navin772 I just tried again, and the issue still occurs when running your code. It loads |
@cgoldberg, just confirming, did you change this value here to: Also, in which directory did you start the http server? Can you also go to For me, in my linux device, I am easily able to trigger the FedCM dialog box. |
@navin772 very sorry... I just tried again and I had it configured incorrectly. The dialog DOES eventually open, it just takes a while. So this looks like a timing issue and bumping the timeout up in the tests will likely fix it. |
Thanks @cgoldberg, this looks good! |
Description
I'm not even sure what FedCM is/does, but there is a Python test in Selenium's CI that keeps failing:
py/test/selenium/webdriver/common/fedcm_tests.py
When I run this test locally, I get 2 failures:
They both seem to be timing out waiting for the FedCM dialog to open. I can reproduce this using the code below.
Environment info:
Reproducible Code
Debugging Logs
ℹ️ Last known working version:
N/A
The text was updated successfully, but these errors were encountered: