newSessionWaitTimeout doesn't wpork

[tillias]

🐛 Bug Report

newSessionWaitTimeout for selenium grid doesn't work. The chrome-node hangs and is not released

To Reproduce

Following configuration is used:

{
  "host": "0.0.0.0",
  "port": 4444,
  "role": "hub",
  "maxSession": 5,
  "newSessionWaitTimeout": 30,
  "capabilityMatcher": "org.openqa.grid.internal.utils.DefaultCapabilityMatcher",
  "throwOnCapabilityNotPresent": true,
  "jettyMaxThreads": -1,
  "cleanUpCycle": 5000,
  "browserTimeout": 10,
  "timeout": 1800,
  "debug": false
}

Detailed steps to reproduce the behavior:

Start selenium-hub and chrome-node. Run any test on it which doesn't close session / driver (or run any selenium test in debug mode and then stop it in the middle)

Expected behavior

node is released afer newSessionWaitTimeout

Actual behavior

Node hangs, no cleanup is performed on hub

12:55:31.061 INFO [RequestHandler.process] - Got a request to create a new session: Capabilities {browserName: chrome, goog:chromeOptio
ns: {args: [], extensions: []}}
12:55:31.064 INFO [TestSlot.getNewSession] - Trying to create a new session on test slot {server:CONFIG_UUID=edd41d74-d084-4c09-83c1-cf
8d44d42f49, seleniumProtocol=WebDriver, browserName=chrome, maxInstances=1, platformName=LINUX, version=76.0.3809.87, applicationName=,
 platform=LINUX}

Environment

Selenium Grid version (if applicable): 3.141.59

[diemol]

Hi @tillias

From

java -jar selenium-server-standalone-3.141.59.jar -role hub -help

   -newSessionWaitTimeout
      <Integer> in ms : The time after which a new test waiting for a node to
      become available will time out. When that happens, the test will throw
      an exception before attempting to start a browser. An unspecified, zero,
      or negative value means wait indefinitely.

What you are looking for is:

 -timeout, -sessionTimeout
      <Integer> in seconds : Specifies the timeout before the server
      automatically kills a session that hasn't had any activity in the last X
      seconds. The test slot will then be released for another test to use.
      This is typically used to take care of client crashes. For grid hub/node
      roles, cleanUpCycle must also be set. If a node does not specify it, the
      hub value will be used.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.