From 1250fcaa270be642d8efb1da2791edbb53dc3883 Mon Sep 17 00:00:00 2001 From: Maciej Kucharczyk Date: Thu, 10 Oct 2024 20:07:02 +0200 Subject: [PATCH 1/2] Fix condition --- java/src/org/openqa/selenium/devtools/v127/v127Network.java | 2 +- java/src/org/openqa/selenium/devtools/v128/v128Network.java | 2 +- java/src/org/openqa/selenium/devtools/v129/v129Network.java | 2 +- java/src/org/openqa/selenium/devtools/v85/V85Network.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/java/src/org/openqa/selenium/devtools/v127/v127Network.java b/java/src/org/openqa/selenium/devtools/v127/v127Network.java index d430a582b2358..76b9b93d5aa8f 100644 --- a/java/src/org/openqa/selenium/devtools/v127/v127Network.java +++ b/java/src/org/openqa/selenium/devtools/v127/v127Network.java @@ -127,7 +127,7 @@ public Either createSeMessages(RequestPaused pausedRe } catch (DevToolsException e) { // Redirects don't seem to have bodies int code = pausedReq.getResponseStatusCode().orElse(HTTP_OK); - if (code < 300 && code > 399) { + if (code < 300 || code > 399) { LOG.warning("Unable to get body for request id " + pausedReq.getRequestId()); } diff --git a/java/src/org/openqa/selenium/devtools/v128/v128Network.java b/java/src/org/openqa/selenium/devtools/v128/v128Network.java index e333a026dfc64..1a91d131e33d4 100644 --- a/java/src/org/openqa/selenium/devtools/v128/v128Network.java +++ b/java/src/org/openqa/selenium/devtools/v128/v128Network.java @@ -127,7 +127,7 @@ public Either createSeMessages(RequestPaused pausedRe } catch (DevToolsException e) { // Redirects don't seem to have bodies int code = pausedReq.getResponseStatusCode().orElse(HTTP_OK); - if (code < 300 && code > 399) { + if (code < 300 || code > 399) { LOG.warning("Unable to get body for request id " + pausedReq.getRequestId()); } diff --git a/java/src/org/openqa/selenium/devtools/v129/v129Network.java b/java/src/org/openqa/selenium/devtools/v129/v129Network.java index 41c76f9897c46..252b4066f5b0c 100644 --- a/java/src/org/openqa/selenium/devtools/v129/v129Network.java +++ b/java/src/org/openqa/selenium/devtools/v129/v129Network.java @@ -127,7 +127,7 @@ public Either createSeMessages(RequestPaused pausedRe } catch (DevToolsException e) { // Redirects don't seem to have bodies int code = pausedReq.getResponseStatusCode().orElse(HTTP_OK); - if (code < 300 && code > 399) { + if (code < 300 || code > 399) { LOG.warning("Unable to get body for request id " + pausedReq.getRequestId()); } diff --git a/java/src/org/openqa/selenium/devtools/v85/V85Network.java b/java/src/org/openqa/selenium/devtools/v85/V85Network.java index da12dbe42802d..42409cf5850f4 100644 --- a/java/src/org/openqa/selenium/devtools/v85/V85Network.java +++ b/java/src/org/openqa/selenium/devtools/v85/V85Network.java @@ -137,7 +137,7 @@ public Either createSeMessages(RequestPaused pausedRe } catch (DevToolsException e) { // Redirects don't seem to have bodies int code = pausedReq.getResponseStatusCode().orElse(HTTP_OK); - if (code < 300 && code > 399) { + if (code < 300 || code > 399) { LOG.warning("Unable to get body for request id " + pausedReq.getRequestId()); } From bc204fa2999f6497c1f9d5ec51caeb14f1a72892 Mon Sep 17 00:00:00 2001 From: mk868 Date: Fri, 11 Oct 2024 09:00:12 +0200 Subject: [PATCH 2/2] apply review suggestions --- java/src/org/openqa/selenium/devtools/v127/v127Network.java | 2 +- java/src/org/openqa/selenium/devtools/v128/v128Network.java | 2 +- java/src/org/openqa/selenium/devtools/v129/v129Network.java | 2 +- java/src/org/openqa/selenium/devtools/v85/V85Network.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/java/src/org/openqa/selenium/devtools/v127/v127Network.java b/java/src/org/openqa/selenium/devtools/v127/v127Network.java index 76b9b93d5aa8f..769c646c40e7b 100644 --- a/java/src/org/openqa/selenium/devtools/v127/v127Network.java +++ b/java/src/org/openqa/selenium/devtools/v127/v127Network.java @@ -127,7 +127,7 @@ public Either createSeMessages(RequestPaused pausedRe } catch (DevToolsException e) { // Redirects don't seem to have bodies int code = pausedReq.getResponseStatusCode().orElse(HTTP_OK); - if (code < 300 || code > 399) { + if (code >= 300 && code <= 399) { LOG.warning("Unable to get body for request id " + pausedReq.getRequestId()); } diff --git a/java/src/org/openqa/selenium/devtools/v128/v128Network.java b/java/src/org/openqa/selenium/devtools/v128/v128Network.java index 1a91d131e33d4..ccbdcee9426f3 100644 --- a/java/src/org/openqa/selenium/devtools/v128/v128Network.java +++ b/java/src/org/openqa/selenium/devtools/v128/v128Network.java @@ -127,7 +127,7 @@ public Either createSeMessages(RequestPaused pausedRe } catch (DevToolsException e) { // Redirects don't seem to have bodies int code = pausedReq.getResponseStatusCode().orElse(HTTP_OK); - if (code < 300 || code > 399) { + if (code >= 300 && code <= 399) { LOG.warning("Unable to get body for request id " + pausedReq.getRequestId()); } diff --git a/java/src/org/openqa/selenium/devtools/v129/v129Network.java b/java/src/org/openqa/selenium/devtools/v129/v129Network.java index 252b4066f5b0c..21651783d74cf 100644 --- a/java/src/org/openqa/selenium/devtools/v129/v129Network.java +++ b/java/src/org/openqa/selenium/devtools/v129/v129Network.java @@ -127,7 +127,7 @@ public Either createSeMessages(RequestPaused pausedRe } catch (DevToolsException e) { // Redirects don't seem to have bodies int code = pausedReq.getResponseStatusCode().orElse(HTTP_OK); - if (code < 300 || code > 399) { + if (code >= 300 && code <= 399) { LOG.warning("Unable to get body for request id " + pausedReq.getRequestId()); } diff --git a/java/src/org/openqa/selenium/devtools/v85/V85Network.java b/java/src/org/openqa/selenium/devtools/v85/V85Network.java index 42409cf5850f4..c4bc0df6219ce 100644 --- a/java/src/org/openqa/selenium/devtools/v85/V85Network.java +++ b/java/src/org/openqa/selenium/devtools/v85/V85Network.java @@ -137,7 +137,7 @@ public Either createSeMessages(RequestPaused pausedRe } catch (DevToolsException e) { // Redirects don't seem to have bodies int code = pausedReq.getResponseStatusCode().orElse(HTTP_OK); - if (code < 300 || code > 399) { + if (code >= 300 && code <= 399) { LOG.warning("Unable to get body for request id " + pausedReq.getRequestId()); }