From 4070ad0506fe1a1af33efd8940e098f856c53ca2 Mon Sep 17 00:00:00 2001 From: Simon Benzer Date: Tue, 29 Oct 2024 14:44:20 -0400 Subject: [PATCH 1/2] [py] Added Deprecation of WebElement.get_attribute() per #13334 --- py/selenium/webdriver/remote/webelement.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/py/selenium/webdriver/remote/webelement.py b/py/selenium/webdriver/remote/webelement.py index 08c772eaad56e..f47eed649ad3e 100644 --- a/py/selenium/webdriver/remote/webelement.py +++ b/py/selenium/webdriver/remote/webelement.py @@ -173,6 +173,13 @@ def get_attribute(self, name) -> str | None: # Check if the "active" CSS class is applied to an element. is_active = "active" in target_element.get_attribute("class") """ + + warnings.warn( + "using WebElement.get_attribute() has been deprecated. Please use get_dom_attribute() instead." + DeprecationWarning, + stacklevel=2, + ) + if getAttribute_js is None: _load_js() attribute_value = self.parent.execute_script( From b63da1a249eb4ca81a24110d03c7ed55b22afe07 Mon Sep 17 00:00:00 2001 From: Simon Benzer <69980130+shbenzer@users.noreply.github.com> Date: Tue, 29 Oct 2024 15:24:25 -0400 Subject: [PATCH 2/2] missing comma added --- py/selenium/webdriver/remote/webelement.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/py/selenium/webdriver/remote/webelement.py b/py/selenium/webdriver/remote/webelement.py index f47eed649ad3e..e5a3adad0d7b4 100644 --- a/py/selenium/webdriver/remote/webelement.py +++ b/py/selenium/webdriver/remote/webelement.py @@ -175,7 +175,7 @@ def get_attribute(self, name) -> str | None: """ warnings.warn( - "using WebElement.get_attribute() has been deprecated. Please use get_dom_attribute() instead." + "using WebElement.get_attribute() has been deprecated. Please use get_dom_attribute() instead.", DeprecationWarning, stacklevel=2, )