From b1f4ca514b729c52aac1cf477eb695f069774fed Mon Sep 17 00:00:00 2001 From: Alex Date: Sun, 30 Mar 2025 15:43:10 +0700 Subject: [PATCH 1/2] attempt to pass all the headers from the paused reuqest --- .../openqa/selenium/devtools/v134/v134Network.java | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/java/src/org/openqa/selenium/devtools/v134/v134Network.java b/java/src/org/openqa/selenium/devtools/v134/v134Network.java index dc815ae22af3a..2b912ab07e420 100644 --- a/java/src/org/openqa/selenium/devtools/v134/v134Network.java +++ b/java/src/org/openqa/selenium/devtools/v134/v134Network.java @@ -191,7 +191,17 @@ protected Command continueRequest(RequestPaused pausedReq, HttpRequest req } List headers = new ArrayList<>(); - req.forEachHeader((name, value) -> headers.add(new HeaderEntry(name, value))); + + // First add the original headers from the paused request to preserve them + pausedReq.getRequest().getHeaders().forEach( + (name, value) -> headers.add(new HeaderEntry(name, String.valueOf(value)))); + + // Then add any new headers from the modified request, which will override existing ones if present + req.forEachHeader((name, value) -> { + // Remove any existing header with the same name + headers.removeIf(h -> h.getName().equalsIgnoreCase(name)); + headers.add(new HeaderEntry(name, value)); + }); return Fetch.continueRequest( pausedReq.getRequestId(), From a898f9d53de55b7ddb52733f9e3cf8b812294e65 Mon Sep 17 00:00:00 2001 From: Alex Date: Sun, 30 Mar 2025 17:39:05 +0700 Subject: [PATCH 2/2] applied format.sh --- .../selenium/devtools/v134/v134Network.java | 24 +++++++++++-------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/java/src/org/openqa/selenium/devtools/v134/v134Network.java b/java/src/org/openqa/selenium/devtools/v134/v134Network.java index 2b912ab07e420..04d2b0baf31e4 100644 --- a/java/src/org/openqa/selenium/devtools/v134/v134Network.java +++ b/java/src/org/openqa/selenium/devtools/v134/v134Network.java @@ -191,17 +191,21 @@ protected Command continueRequest(RequestPaused pausedReq, HttpRequest req } List headers = new ArrayList<>(); - + // First add the original headers from the paused request to preserve them - pausedReq.getRequest().getHeaders().forEach( - (name, value) -> headers.add(new HeaderEntry(name, String.valueOf(value)))); - - // Then add any new headers from the modified request, which will override existing ones if present - req.forEachHeader((name, value) -> { - // Remove any existing header with the same name - headers.removeIf(h -> h.getName().equalsIgnoreCase(name)); - headers.add(new HeaderEntry(name, value)); - }); + pausedReq + .getRequest() + .getHeaders() + .forEach((name, value) -> headers.add(new HeaderEntry(name, String.valueOf(value)))); + + // Then add any new headers from the modified request, which will override existing ones if + // present + req.forEachHeader( + (name, value) -> { + // Remove any existing header with the same name + headers.removeIf(h -> h.getName().equalsIgnoreCase(name)); + headers.add(new HeaderEntry(name, value)); + }); return Fetch.continueRequest( pausedReq.getRequestId(),