Fixes and completes install_addon() tests on firefox

test_install_addon_directory() was being called with an xpi file
fixture instead of a directory fixture.

I fixed this by making a new fixture for
test_install_addon_directory() that points to the test extension
directory. See details here below.

I also added an additional test and fixture so that the tests
take into account whether a path to an extension directory ends
with a trailing slash. See details here below.

This required renaming the existing addon_path fixture to avoid
confusion among the three related fixtures:

- addon_path_xpi

  renamed fixture gives a path to the xpi file (was addon_path)

  updated test_install_add() and test_unistall_addon()

- addon_path_dir

  new fixture that gives a path to the extension directory,
  ending without a '/'

  updated test_install_unsigned_addon_directory() to use it

- addon_path_dir_slash (new fixture, and test)

  new fixture that gives a path to the extension directory,
  ending with a '/'

  added new test: test_install_unsigned_addon_directory_slash()

Note that I don't have the appropriate environment to run these tests
before pushing them.

Author: jkbzh

examples/python/tests/browsers/test_firefox.py

@@ -88,31 +88,42 @@ def test_profile_location(temp_dir):
     driver.quit()
 
 
-def test_install_addon(firefox_driver, addon_path):
+def test_install_addon(firefox_driver, addon_path_xpi):
     driver = firefox_driver
 
-    driver.install_addon(addon_path)
+    driver.install_addon(addon_path_xpi)
 
     driver.get("https://www.selenium.dev/selenium/web/blank.html")
     injected = driver.find_element(webdriver.common.by.By.ID, "webextensions-selenium-example")
 
     assert injected.text == "Content injected by webextensions-selenium-example"
 
 
-def test_uninstall_addon(firefox_driver, addon_path):
+def test_uninstall_addon(firefox_driver, addon_path_xpi):
     driver = firefox_driver
 
-    id = driver.install_addon(addon_path)
+    id = driver.install_addon(addon_path_xpi)
     driver.uninstall_addon(id)
 
     driver.get("https://www.selenium.dev/selenium/web/blank.html")
     assert len(driver.find_elements(webdriver.common.by.By.ID, "webextensions-selenium-example")) == 0
 
 
-def test_install_unsigned_addon_directory(firefox_driver, addon_path):
+def test_install_unsigned_addon_directory(firefox_driver, addon_path_dir):
     driver = firefox_driver
 
-    driver.install_addon(addon_path, temporary=True)
+    driver.install_addon(addon_path_dir, temporary=True)
+
+    driver.get("https://www.selenium.dev/selenium/web/blank.html")
+    injected = driver.find_element(webdriver.common.by.By.ID, "webextensions-selenium-example")
+
+    assert injected.text == "Content injected by webextensions-selenium-example"
+
+
+def test_install_unsigned_addon_directory_slash(firefox_driver, addon_path_dir_slash):
+    driver = firefox_driver
+
+    driver.install_addon(addon_path_dir_slash, temporary=True)
 
     driver.get("https://www.selenium.dev/selenium/web/blank.html")
     injected = driver.find_element(webdriver.common.by.By.ID, "webextensions-selenium-example")

examples/python/tests/conftest.py

@@ -94,7 +94,7 @@ def log_path():
 
 
 @pytest.fixture(scope='function')
-def addon_path():
+def addon_path_xpi():
     if os.path.abspath("").endswith("tests"):
         path = os.path.abspath("extensions/webextensions-selenium-example.xpi")
     else:
@@ -103,6 +103,26 @@ def addon_path():
     yield path
 
 
+@pytest.fixture(scope='function')
+def addon_path_dir():
+    if os.path.abspath("").endswith("tests"):
+        path = os.path.abspath("extensions/webextensions-selenium-example")
+    else:
+        path = os.path.abspath("tests/extensions/webextensions-selenium-example")
+
+    yield path
+
+
+@pytest.fixture(scope='function')
+def addon_path_dir_slash():
+    if os.path.abspath("").endswith("tests"):
+        path = os.path.abspath("extensions/webextensions-selenium-example/")
+    else:
+        path = os.path.abspath("tests/extensions/webextensions-selenium-example/")
+
+    yield path
+
+
 @pytest.fixture(scope="function")
 def server_old(request):
     _host = "localhost"