Merge branch 'trunk' into page-component-objects

Author: diemol

examples/dotnet/SeleniumDocs/GettingStarted/InstallDriversTest.cs

@@ -12,7 +12,6 @@
       <PackageReference Include="MSTest.TestFramework" Version="2.2.10" />
       <PackageReference Include="Selenium.Support" Version="4.5.0" />
       <PackageReference Include="Selenium.WebDriver" Version="4.9.0" />
-      <PackageReference Include="WebDriverManager" Version="2.16.0" />
     </ItemGroup>
 
     <ItemGroup>

examples/dotnet/SeleniumDocs/SeleniumDocs.csproj

@@ -12,7 +12,6 @@ repositories {
 dependencies {
     testImplementation 'org.seleniumhq.selenium:selenium-java:4.9.1'
     testImplementation 'org.seleniumhq.selenium:selenium-grid:4.9.1'
-    testImplementation 'io.github.bonigarcia:webdrivermanager:5.3.2'
     testImplementation 'org.junit.jupiter:junit-jupiter-engine:5.9.0'
 }
 

examples/java/build.gradle

@@ -56,12 +56,6 @@
             <version>5.9.2</version>
             <scope>test</scope>
         </dependency>
-        <dependency>
-            <groupId>io.github.bonigarcia</groupId>
-            <artifactId>webdrivermanager</artifactId>
-            <version>5.3.2</version>
-            <scope>test</scope>
-        </dependency>
     </dependencies>
 
     <build>

examples/java/pom.xml

@@ -54,12 +54,6 @@
             <version>${junit5.version}</version>
             <scope>test</scope>
         </dependency>
-        <dependency>
-            <groupId>io.github.bonigarcia</groupId>
-            <artifactId>webdrivermanager</artifactId>
-            <version>${wdm.version}</version>
-            <scope>test</scope>
-        </dependency>
         <dependency>
             <groupId>org.jetbrains.kotlin</groupId>
             <artifactId>kotlin-stdlib-jdk8</artifactId>

examples/java/src/test/java/dev/selenium/getting_started/InstallDriversTest.java

@@ -1,6 +1,5 @@
 package dev.selenium;
 
-import io.github.bonigarcia.wdm.WebDriverManager;
 import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.BeforeEach;
@@ -12,11 +11,6 @@ import org.junit.jupiter.api.TestInstance
 open class BaseTest {
     lateinit var driver: WebDriver
 
-    @BeforeAll
-    fun setupAll() {
-        WebDriverManager.chromedriver().setup()
-    }
-
     @BeforeEach
     fun setup() {
         driver = ChromeDriver()

examples/kotlin/pom.xml

@@ -1,6 +1,5 @@
 package dev.selenium.getting_started
 
-import io.github.bonigarcia.wdm.WebDriverManager
 import org.junit.jupiter.api.*
 import org.junit.jupiter.api.Assertions.assertEquals
 import org.openqa.selenium.By
@@ -12,23 +11,10 @@ import java.time.Duration
 class FirstScriptTest {
     private lateinit var driver: WebDriver
 
-    @BeforeAll
-    fun setupAll() {
-        WebDriverManager.chromedriver().setup()
-    }
-
-    @BeforeEach
-    fun setup() {
-        driver = ChromeDriver()
-    }
-
-    @AfterEach
-    fun teardown() {
-        driver.quit()
-    }
-
     @Test
     fun eightComponents() {
+        driver = ChromeDriver()
+
         driver.get("https://www.selenium.dev/selenium/web/web-form.html")
 
         val title = driver.title
@@ -45,6 +31,8 @@ class FirstScriptTest {
         val message = driver.findElement(By.id("message"))
         val value = message.getText()
         assertEquals("Received!", value)
+
+        driver.quit()
     }
 
 }

examples/kotlin/src/test/kotlin/dev/selenium/BaseTest.kt

@@ -1,4 +1,3 @@
 selenium==4.9.1
 pytest
 flake8
-webdriver_manager==3.8.3

examples/kotlin/src/test/kotlin/dev/selenium/getting_started/FirstScriptTest.kt

@@ -14,6 +14,7 @@ def driver():
 @pytest.fixture(scope='function')
 def firefox_driver():
     driver = webdriver.Firefox()
+    driver.implicitly_wait(1)
 
     yield driver
 

examples/kotlin/src/test/kotlin/dev/selenium/getting_started/InstallDriversTest.kt

@@ -1,3 +1,4 @@
+import atexit
 import logging
 import os
 
@@ -24,4 +25,6 @@ def test_logging():
         with open(log_path, 'r') as fp:
             assert len(fp.readlines()) == 3
     finally:
-        os.remove(log_path)
+        atexit.register(delete_path, log_path)
+def delete_path(path):
+    os.remove(path)

examples/python/requirements.txt

@@ -8,4 +8,3 @@ gem 'rspec', '~> 3.0'
 gem 'rubocop', '~> 1.35'
 gem 'rubocop-rspec', '~> 2.12'
 gem 'selenium-webdriver', '= 4.9.1'
-gem 'webdrivers', '~> 5.1'

examples/python/tests/conftest.py

@@ -191,7 +191,7 @@ A basic comparison of code looks like:
     {{</* gh-codeblock path="examples/javascript/test/getting_started/firstScript.spec.js#L23-L24" */>}}
     {{</* /tab */>}}
     {{</* tab header="Kotlin" */>}}
-    {{</* gh-codeblock path="examples/kotlin/src/test/kotlin/dev/selenium/getting_started/FirstScriptTest.kt#L39-L40" */>}}
+    {{</* gh-codeblock path="examples/kotlin/src/test/kotlin/dev/selenium/getting_started/FirstScriptTest.kt#L25-L26" */>}}
     {{</* /tab */>}}
     {{</* /tabpane */>}}
 
@@ -214,7 +214,7 @@ Which looks like this:
 {{< gh-codeblock path="examples/javascript/test/getting_started/firstScript.spec.js#L23-L24" >}}
 {{< /tab >}}
 {{< tab header="Kotlin" >}}
-{{< gh-codeblock path="examples/kotlin/src/test/kotlin/dev/selenium/getting_started/FirstScriptTest.kt#L39-L40" >}}
+{{< gh-codeblock path="examples/kotlin/src/test/kotlin/dev/selenium/getting_started/FirstScriptTest.kt#L25-L26" >}}
 {{< /tab >}}
 {{< /tabpane >}}