Merge branch 'trunk' into expand_options_example_page

Author: aguspe

Diff for: examples/javascript/package-lock.json

@@ -8,7 +8,7 @@
     "license": "Apache-2.0",
     "dependencies": {
         "assert": "2.1.0",
-        "selenium-webdriver": "4.19.0"
+        "selenium-webdriver": "4.20.0"
     },
     "devDependencies": {
         "mocha": "10.4.0"

Diff for: examples/javascript/package.json

@@ -8,4 +8,4 @@ gem 'rspec', '~> 3.0'
 gem 'rubocop', '~> 1.35'
 gem 'rubocop-rspec', '~> 2.12'
 gem 'selenium-devtools', '= 0.124.0'
-gem 'selenium-webdriver', '= 4.19.0'
+gem 'selenium-webdriver', '= 4.20.0'

Diff for: examples/ruby/Gemfile

@@ -56,7 +56,7 @@ GEM
     rubyzip (2.3.2)
     selenium-devtools (0.124.0)
       selenium-webdriver (~> 4.2)
-    selenium-webdriver (4.19.0)
+    selenium-webdriver (4.20.0)
       base64 (~> 0.2)
       rexml (~> 3.2, >= 3.2.5)
       rubyzip (>= 1.2.2, < 3.0)
@@ -78,7 +78,7 @@ DEPENDENCIES
   rubocop (~> 1.35)
   rubocop-rspec (~> 2.12)
   selenium-devtools (= 0.124.0)
-  selenium-webdriver (= 4.19.0)
+  selenium-webdriver (= 4.20.0)
 
 BUNDLED WITH
    2.5.6

Diff for: examples/ruby/Gemfile.lock

@@ -115,7 +115,8 @@
 
   def driver_finder
     options = Selenium::WebDriver::Options.chrome(browser_version: 'stable')
-    ENV['CHROMEDRIVER_BIN'] = Selenium::WebDriver::DriverFinder.path(options, Selenium::WebDriver::Chrome::Service)
-    ENV['CHROME_BIN'] = options.binary
+    finder = Selenium::WebDriver::DriverFinder.new(options, Selenium::WebDriver::Chrome::Service)
+    ENV['CHROMEDRIVER_BIN'] = finder.driver_path
+    ENV['CHROME_BIN'] = finder.browser_path
   end
 end

Diff for: examples/ruby/spec/browsers/chrome_spec.rb

@@ -115,7 +115,8 @@
 
   def driver_finder
     options = Selenium::WebDriver::Options.edge(browser_version: 'stable')
-    ENV['EDGEDRIVER_BIN'] = Selenium::WebDriver::DriverFinder.path(options, Selenium::WebDriver::Edge::Service)
-    ENV['EDGE_BIN'] = options.binary
+    finder = Selenium::WebDriver::DriverFinder.new(options, Selenium::WebDriver::Edge::Service)
+    ENV['EDGEDRIVER_BIN'] = finder.driver_path
+    ENV['EDGE_BIN'] = finder.browser_path
   end
 end

Diff for: examples/ruby/spec/browsers/edge_spec.rb

@@ -122,7 +122,8 @@
 
   def driver_finder
     options = Selenium::WebDriver::Options.firefox(browser_version: 'stable')
-    ENV['GECKODRIVER_BIN'] = Selenium::WebDriver::DriverFinder.path(options, Selenium::WebDriver::Firefox::Service)
-    ENV['FIREFOX_BIN'] = options.binary
+    finder = Selenium::WebDriver::DriverFinder.new(options, Selenium::WebDriver::Firefox::Service)
+    ENV['GECKODRIVER_BIN'] = finder.driver_path
+    ENV['FIREFOX_BIN'] = finder.browser_path
   end
 end

Diff for: examples/ruby/spec/browsers/firefox_spec.rb

@@ -33,7 +33,8 @@
 
   def driver_finder
     options = Selenium::WebDriver::Options.chrome(browser_version: 'stable')
-    ENV['CHROMEDRIVER_BIN'] = Selenium::WebDriver::DriverFinder.path(options, Selenium::WebDriver::Chrome::Service)
-    ENV['CHROME_BIN'] = options.binary
+    finder = Selenium::WebDriver::DriverFinder.new(options, Selenium::WebDriver::Chrome::Service)
+    ENV['CHROMEDRIVER_BIN'] = finder.driver_path
+    ENV['CHROME_BIN'] = finder.browser_path
   end
 end