Callback data should exclude children

[levithomason]

We currently provide (e, data) in all callbacks. This is very useful as the data usually includes props, significant state, and any proposed new values. However, children should be removed.

We should encapsulate the handling of our callback data in a lib function getCallbackData():

Before

const data = { ...this.props, checked: !checked, indeterminate: false }
_.invoke(this.props, 'onChange', e, data)

After

const data = getCallbackData({ ...this.props, checked: !checked, indeterminate: false })
_.invoke(this.props, 'onChange', e, data)

Why?

1. It is an opaque data structure that is not to be touched directly.
2. It is extremely large as it contains the entire tree of ancestors via the _owner._currentElement references.
3. There are references to children's refs and keys in here, again not something you should be messing with.

---

The motivation for this issue came form using Storybook with the actions addon. The callback args are logged. They are parsed with a circular JSON safe parser first. Because the children prop is so massive, this gives a huge performance hit.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.

[levithomason]

Thanks to @rijk, we have improved how we handle stale issues, see #2761. Reopening.

[stale]

There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

[layershifter]

Unstale, please :cat

[stale]

There has been no activity in this thread for 180 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

[stale]

This issue will be closed due to lack of activity for 12 months. If you’d like this to be reopened, just leave a comment; we do monitor them!