Skip to content

Checkbox: slider is not clickable in the entire area #3502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
felixmosh opened this issue Mar 14, 2019 · 8 comments · Fixed by #3693
Closed

Checkbox: slider is not clickable in the entire area #3502

felixmosh opened this issue Mar 14, 2019 · 8 comments · Fixed by #3693

Comments

@felixmosh
Copy link
Contributor

Bug Report

If you click in the space between the nub & the line it won't trigger the handler

Steps

click in the are of the arrow
image

Expected Result

It should allow click on the checkbox in that area.

Actual Result

It not clicks there, therefore it is hard to click on the toggle.

Version

0.86.0

Testcase

It should work as the jQuery version that is clickable in that area.
Checkout how it works https://semantic-ui.com/modules/checkbox.html#fitted

@ghost ghost added the triage label Mar 14, 2019
@layershifter
Copy link
Member

With label

SUI Slider

sui-slider

SUIR Slider

suir-slider

Works fine ⭐️


Without label

SUI 👍

sui-slider-bug

SUIR 💣

suir-slider-bug

@ghost ghost removed the triage label Mar 15, 2019
@layershifter layershifter changed the title Slider Checkbox not clickable in the entire area Checkbox: slider is not clickable in the entire area Mar 15, 2019
@wvha
Copy link

wvha commented Mar 16, 2019

I'm not exactly sure what the "hidden" classname does besides negative z-index, but if you remove it from the input element, the slider becomes clickable in the entire area, however this makes the label text have the wrong cursor on hover

@felixmosh
Copy link
Contributor Author

It is possible to fix with given a label min-height of 1rem, the problem is that this change should be done in semantic-ui css, what is the best practice regarding scenarios such that?

@felixmosh
Copy link
Contributor Author

Ping

@layershifter
Copy link
Member

I think that issue is around #3435, we partially handle clicks on label while for slider we should handle them fully. It's an initial suggestion.

@felixmosh
Copy link
Contributor Author

felixmosh commented Mar 25, 2019

@layershifter the issue is that the label is with height of 0px.
image

Otherwise, if I add it a min-height it starts to work (with the hover effect) as expected.
image

image

@felixmosh
Copy link
Contributor Author

Should I add the min-height to the label in semantic-ui css, or I can add it to inline style of the component.

@layershifter WDYT?

@layershifter
Copy link
Member

@felixmosh this should be fixed on our side, fix is coming in #3693.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants