Skip to content

Commit bed8fac

Browse files
saurabhraghuvanshiiShabiShett07
authored andcommitted
chore: address commit comments
PR-URL: stdlib-js#5219 Closes: stdlib-js#5125 Reviewed-by: Athan Reines <[email protected]>
1 parent e223021 commit bed8fac

File tree

2 files changed

+5
-15
lines changed

2 files changed

+5
-15
lines changed

lib/node_modules/@stdlib/stats/base/dists/binomial/mean/benchmark/benchmark.native.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ var bench = require( '@stdlib/bench' );
2525
var Int32Array = require( '@stdlib/array/int32' );
2626
var Float64Array = require( '@stdlib/array/float64' );
2727
var tryRequire = require( '@stdlib/utils/try-require' );
28-
var ceil = require( '@stdlib/math/base/special/ceil' );
29-
var randu = require( '@stdlib/random/base/randu' );
28+
var uniform = require( '@stdlib/random/base/uniform' );
29+
var discreteUniform = require( '@stdlib/random/base/discrete-uniform' );
3030
var isnan = require( '@stdlib/math/base/assert/is-nan' );
3131
var pkg = require( './../package.json' ).name;
3232

@@ -52,8 +52,8 @@ bench( pkg+'::native', opts, function benchmark( b ) {
5252
n = new Int32Array( len );
5353
p = new Float64Array( len );
5454
for ( i = 0; i < len; i++ ) {
55-
n[ i ] = ceil( randu() * 100.0 );
56-
p[ i ] = randu();
55+
n[ i ] = discreteUniform( 1, 100 );
56+
p[ i ] = uniform( 0.0, 1.0 );
5757
}
5858

5959
b.tic();

lib/node_modules/@stdlib/stats/base/dists/binomial/mean/test/test.native.js

+1-11
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ var resolve = require( 'path' ).resolve;
2424
var tape = require( 'tape' );
2525
var tryRequire = require( '@stdlib/utils/try-require' );
2626
var isnan = require( '@stdlib/math/base/assert/is-nan' );
27-
var abs = require( '@stdlib/math/base/special/abs' );
28-
var EPS = require( '@stdlib/constants/float64/eps' );
2927

3028

3129
// FIXTURES //
@@ -75,8 +73,6 @@ tape( 'if provided `n < 0` or success probability `p` outside of `[0,1]`, the fu
7573

7674
tape( 'the function returns the mean of a binomial distribution', opts, function test( t ) {
7775
var expected;
78-
var delta;
79-
var tol;
8076
var i;
8177
var n;
8278
var p;
@@ -87,13 +83,7 @@ tape( 'the function returns the mean of a binomial distribution', opts, function
8783
p = data.p;
8884
for ( i = 0; i < expected.length; i++ ) {
8985
y = mean( n[i], p[i] );
90-
if ( y === expected[i] ) {
91-
t.equal( y, expected[i], 'n: '+n[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] );
92-
} else {
93-
delta = abs( y - expected[ i ] );
94-
tol = 1.0 * EPS * abs( expected[ i ] );
95-
t.ok( delta <= tol, 'within tolerance. n: '+n[i]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
96-
}
86+
t.equal( y, expected[i], 'n: '+n[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] );
9787
}
9888
t.end();
9989
});

0 commit comments

Comments
 (0)