Revert "fix(ui_auth): add showPasswordVisibilityToggle to the SignInScreen (firebase#114)"

This reverts commit 77ed75d.

Author: ShahoodulHassan

packages/firebase_ui_auth/doc/README.md

@@ -42,34 +42,7 @@ Future<void> main() async {
 
 ## macOS entitlements
 
-If you're building for macOS, make sure to add necessary entitlements. Learn more [from the official Flutter documentation](https://docs.flutter.dev/platform-integration/macos/building#setting-up-entitlements).
-
-## Writing widget unit tests
-
-If you're writing widget unit tests, you'll need to add the following to your `setUpAll` method:
-
-```dart
-setUpAll(() {
-  setFirebaseUiIsTestMode(true);
-});
-```
-
-Also, you will likely want to mock the `FirebaseAuth` instance:
-
-```dart
-class MockFirebaseAuth extends Mock implements FirebaseAuth {
-  /// mock necessary methods
-}
-```
-
-An instance of `MockFirebaseAuth` can then be passed to Firebase UI widgets:
-
-```dart
-SignInScreen(
-  auth: MockFirebaseAuth(),
-  /// ... other props
-)
-```
+If you're building for macOS, make sure to add necessary entitlements. Learn more [from the official Flutter documentation](https://docs.flutter.dev/development/platform-integration/macos/building).
 
 ## Next steps
 

packages/firebase_ui_auth/example/windows/flutter/generated_plugin_registrant.cc

@@ -7,15 +7,12 @@
 #include "generated_plugin_registrant.h"
 
 #include <desktop_webview_auth/desktop_webview_auth_plugin.h>
-#include <firebase_auth/firebase_auth_plugin_c_api.h>
 #include <firebase_core/firebase_core_plugin_c_api.h>
 #include <flutter_secure_storage_windows/flutter_secure_storage_windows_plugin.h>
 
 void RegisterPlugins(flutter::PluginRegistry* registry) {
   DesktopWebviewAuthPluginRegisterWithRegistrar(
       registry->GetRegistrarForPlugin("DesktopWebviewAuthPlugin"));
-  FirebaseAuthPluginCApiRegisterWithRegistrar(
-      registry->GetRegistrarForPlugin("FirebaseAuthPluginCApi"));
   FirebaseCorePluginCApiRegisterWithRegistrar(
       registry->GetRegistrarForPlugin("FirebaseCorePluginCApi"));
   FlutterSecureStorageWindowsPluginRegisterWithRegistrar(

packages/firebase_ui_auth/example/windows/flutter/generated_plugins.cmake

@@ -4,7 +4,6 @@
 
 list(APPEND FLUTTER_PLUGIN_LIST
   desktop_webview_auth
-  firebase_auth
   firebase_core
   flutter_secure_storage_windows
 )

packages/firebase_ui_auth/lib/firebase_ui_auth.dart

@@ -95,13 +95,6 @@ export 'src/widgets/sign_out_button.dart';
 export 'src/widgets/sms_code_input.dart' show SMSCodeInputState, SMSCodeInput;
 export 'src/widgets/user_avatar.dart';
 
-bool _isTestMode = false;
-
-@visibleForTesting
-void setFirebaseUiIsTestMode(bool isTestMode) {
-  _isTestMode = isTestMode;
-}
-
 class FirebaseUIAuth {
   static final _providers = <FirebaseApp, List<AuthProvider>>{};
   static final _configuredApps = <FirebaseApp, bool>{};
@@ -111,15 +104,14 @@ class FirebaseUIAuth {
   }
 
   static bool isAppConfigured(FirebaseApp app) {
-    if (_isTestMode) return true;
     return _providers.containsKey(app);
   }
 
   static void configureProviders(
     List<AuthProvider> configs, {
     FirebaseApp? app,
   }) {
-    if (!_isTestMode && Firebase.apps.isEmpty) {
+    if (Firebase.apps.isEmpty) {
       throw Exception(
         'You must call Firebase.initializeApp() '
         'before calling configureProviders()',

packages/firebase_ui_auth/lib/src/screens/sign_in_screen.dart

@@ -95,9 +95,6 @@ class SignInScreen extends MultiProviderScreen {
   /// * [EmailFormStyle]
   final Set<FirebaseUIStyle>? styles;
 
-  /// {@macro ui.auth.widgets.email_form.showPasswordVisibilityToggle}
-  final bool showPasswordVisibilityToggle;
-
   /// {@macro ui.auth.screens.sign_in_screen}
   const SignInScreen({
     super.key,
@@ -117,7 +114,6 @@ class SignInScreen extends MultiProviderScreen {
     this.actions = const [],
     this.breakpoint = 800,
     this.styles,
-    this.showPasswordVisibilityToggle = false,
   });
 
   Future<void> _signInWithDifferentProvider(
@@ -169,7 +165,6 @@ class SignInScreen extends MultiProviderScreen {
         subtitleBuilder: subtitleBuilder,
         footerBuilder: footerBuilder,
         breakpoint: breakpoint,
-        showPasswordVisibilityToggle: showPasswordVisibilityToggle,
       ),
     );
   }

packages/firebase_ui_auth/test/screens/sign_in_screen_test.dart

@@ -8,7 +8,7 @@ import 'package:flutter/material.dart';
 import 'package:flutter/rendering.dart';
 import 'package:flutter_test/flutter_test.dart';
 
-import '../test_utils.dart';
+import '../../test_utils.dart';
 
 void main() {
   group("$LoginView", () {

packages/firebase_ui_auth/test/views/login_view_test.dart renamed to packages/firebase_ui_auth/test/src/views/login_view_test.dart

@@ -3,7 +3,6 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:firebase_auth/firebase_auth.dart';
-import 'package:firebase_core/firebase_core.dart';
 import 'package:firebase_dynamic_links/firebase_dynamic_links.dart';
 import 'package:flutter/material.dart';
 import 'package:mockito/mockito.dart';
@@ -61,19 +60,12 @@ class MockDynamicLinks extends Mock implements FirebaseDynamicLinks {
   Stream<PendingDynamicLinkData> get onLink => _linkStream;
 }
 
-class MockApp extends Mock implements FirebaseApp {}
-
 class MockAuth extends Mock implements FirebaseAuth {
   MockUser? user;
 
   @override
   User? get currentUser => user;
 
-  @override
-  FirebaseApp get app => MockApp();
-
-  List<FirebaseApp> get apps => [app];
-
   @override
   Future<UserCredential> signInWithCredential(
     AuthCredential? credential,

packages/firebase_ui_auth/test/test_utils.dart

@@ -7,14 +7,11 @@
 #include "generated_plugin_registrant.h"
 
 #include <desktop_webview_auth/desktop_webview_auth_plugin.h>
-#include <firebase_auth/firebase_auth_plugin_c_api.h>
 #include <firebase_core/firebase_core_plugin_c_api.h>
 
 void RegisterPlugins(flutter::PluginRegistry* registry) {
   DesktopWebviewAuthPluginRegisterWithRegistrar(
       registry->GetRegistrarForPlugin("DesktopWebviewAuthPlugin"));
-  FirebaseAuthPluginCApiRegisterWithRegistrar(
-      registry->GetRegistrarForPlugin("FirebaseAuthPluginCApi"));
   FirebaseCorePluginCApiRegisterWithRegistrar(
       registry->GetRegistrarForPlugin("FirebaseCorePluginCApi"));
 }

packages/firebase_ui_localizations/example/windows/flutter/generated_plugin_registrant.cc

@@ -4,7 +4,6 @@
 
 list(APPEND FLUTTER_PLUGIN_LIST
   desktop_webview_auth
-  firebase_auth
   firebase_core
 )
 

packages/firebase_ui_localizations/example/windows/flutter/generated_plugins.cmake

@@ -7,15 +7,12 @@
 #include "generated_plugin_registrant.h"
 
 #include <desktop_webview_auth/desktop_webview_auth_plugin.h>
-#include <firebase_auth/firebase_auth_plugin_c_api.h>
 #include <firebase_core/firebase_core_plugin_c_api.h>
 #include <flutter_secure_storage_windows/flutter_secure_storage_windows_plugin.h>
 
 void RegisterPlugins(flutter::PluginRegistry* registry) {
   DesktopWebviewAuthPluginRegisterWithRegistrar(
       registry->GetRegistrarForPlugin("DesktopWebviewAuthPlugin"));
-  FirebaseAuthPluginCApiRegisterWithRegistrar(
-      registry->GetRegistrarForPlugin("FirebaseAuthPluginCApi"));
   FirebaseCorePluginCApiRegisterWithRegistrar(
       registry->GetRegistrarForPlugin("FirebaseCorePluginCApi"));
   FlutterSecureStorageWindowsPluginRegisterWithRegistrar(

packages/firebase_ui_oauth/example/windows/flutter/generated_plugin_registrant.cc

@@ -4,7 +4,6 @@
 
 list(APPEND FLUTTER_PLUGIN_LIST
   desktop_webview_auth
-  firebase_auth
   firebase_core
   flutter_secure_storage_windows
 )