Skip to content

Include sbcs.full.js in Node Package #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephenegriffin opened this issue Jan 4, 2018 · 3 comments
Closed

Include sbcs.full.js in Node Package #14

stephenegriffin opened this issue Jan 4, 2018 · 3 comments

Comments

@stephenegriffin
Copy link

I've found I can get by with sbcs.full.js and not need to load the 2mb cptable.js. However sbcs.full.js isn't available via npm (that I can find). Can we get it added to the package?

@stephenegriffin
Copy link
Author

Confirmed: [email protected] has this file under dist. c5339be slimmed up the package with the side effect of removing this file. Per documentation on https://www.npmjs.com/package/codepage I believe this was unintended.

Recommended fix: Add sbcs.full.js (and maybe sbcs.js) directly to package.json

@SheetJSDev
Copy link
Contributor

@stephenegriffin we just pushed 1.11.1 that added sbcs.full.js to the node module. UNPKG has the file now! Since the code wasn't modified, we didn't rebuild the scripts with the new version number, but 1.12.0 will show the correct version number in the scripts.

@stephenegriffin
Copy link
Author

Awesome - thanks for the unpkg tip too. Totally using that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants