Skip to content

Commit c3af3ee

Browse files
committed
ci: remove race detector on Windows 1.18 (golang/go#46099)
1 parent c019f3d commit c3af3ee

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

.github/workflows/test.yml

+7-4
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@ jobs:
1414
os: [ ubuntu-latest , macos-latest, windows-latest ]
1515
go-version: [ '1.18', '1.19' ]
1616
steps:
17-
- name: Configure git
18-
run: git config --global core.autocrlf false # required on Windows
17+
- name: Configure Windows
18+
if: matrix.os == 'windows-latest'
19+
run: git config --global core.autocrlf false # fixes go lint fmt error
1920
- name: Checkout
2021
uses: actions/checkout@v3
2122
- name: Setup Go
@@ -24,13 +25,15 @@ jobs:
2425
go-version: ${{ matrix.go-version }}
2526
- name: Lint
2627
uses: golangci/golangci-lint-action@v3
28+
- name: Test Windows 1.18 # can't run race detector on windows with go 1.18 or lower due to a bug (https://github.com/golang/go/issues/46099)
29+
if: matrix.os == 'windows-latest' && matrix.go-version == '1.18'
30+
uses: n8maninger/action-golang-test@v1
2731
- name: Test
28-
if: success() || failure() # run even if lint or japecheck fails
32+
if: matrix.os != 'windows-latest' || matrix.go-version != '1.18'
2933
uses: n8maninger/action-golang-test@v1
3034
with:
3135
args: "-race"
3236
- name: Check Endpoints
33-
if: success() || failure() # run even if lint or test fails
3437
shell: bash
3538
run: |
3639
go install go.sia.tech/jape/japecheck@latest

0 commit comments

Comments
 (0)