You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/contributing.md
+36-8
Original file line number
Diff line number
Diff line change
@@ -94,11 +94,39 @@ in next Skript release, whenever that happens.
94
94
95
95
Good luck!
96
96
97
-
### Pull Request Review
98
-
Pull requests require one passing review before they can be merged. In
99
-
addition to that, code submitted by people outside of core team must be tested
100
-
by core team members. In some cases, this might be as simple as running the
101
-
automated tests.
102
-
103
-
In exceptional situations, pull requests may be merged regardless of review
104
-
status by @bensku.
97
+
### Submitting a Contribution
98
+
99
+
Having submitted your contribution it will enter a public review phase.
100
+
101
+
Other contributors and users may make comments or ask questions about your contribution. \
102
+
You are encouraged to respond to these - people may have valuable feedback!
103
+
104
+
Developers may request changes to the content of your pull request. These are valuable since they may concern unreleased content. Please respect our team's wishes - changes are requested when we see room for improvement or necessary issues that need to be addressed.
105
+
Change requests are not an indictment of your code quality.
106
+
107
+
Developers may also request changes to the formatting of your code and attached files. These are important to help maintain the consistent standard and readability of our code base.
108
+
109
+
Once you have made the requested changes (or if you require clarification or assistance) you can request a re-review from the developer.
110
+
111
+
You don't need to keep your pull request fork up-to-date with Skript's master branch - we can update it automatically and notify you if there are any problems.
112
+
113
+
### Merging a Contribution
114
+
115
+
Pull requests may be left un-merged until an appropriate time (e.g. before a suitable release.) This timeframe may be increased for breaking changes or significant new features, which might be better targeted in a major version.
116
+
117
+
Please respect the process - this is a very complex project that takes a lot of time and care to maintain. Your contribution has not been forgotten about.
118
+
119
+
For a contribution to be merged it requires at least two approving reviews from the core development team. It will then require a senior member to merge it.
120
+
121
+
You do not need to 'bump' your contribution if it is un-merged; we may be waiting for a more suitable release to include it.
122
+
123
+
If you have been waiting for a response to a question or change for a significant time please re-request our reviews or contact us.
124
+
125
+
In exceptional situations, pull requests may be merged regardless of review status by one of the organisation admins.
126
+
127
+
### Peaceful Resolution
128
+
129
+
Please respect our maintainers, developers, contributors and users. \
130
+
Our contributors come from a wide variety of backgrounds and countries - you may need to explain issues and requests if they are misunderstood.
131
+
132
+
Please refer disrespectful and unpleasant behaviour to our tracker team. For concerns about abuse, please contact the organisation directly.
0 commit comments