Skip to content

Aliases not properly updated with server after changing #4307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
DieHollanderMC opened this issue Aug 29, 2021 · 7 comments
Closed
1 task done

Aliases not properly updated with server after changing #4307

DieHollanderMC opened this issue Aug 29, 2021 · 7 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.

Comments

@DieHollanderMC
Copy link

DieHollanderMC commented Aug 29, 2021

Skript/Server Version

Replace this text with your output from the command.

Bug Description

I tried using the 'aliases' tag without the use of the 'permission' tag in a command. I figured it wouldn't work when I only put 'aliases' without using another tag.

Expected Behavior

The 'alias' tag should register a command.

Steps to Reproduce

command /test: aliases: t trigger: #action here

Errors or Screenshots

No errors.

Other

No response

Agreement

  • I have read the guidelines above and confirm I am following them with this report.
@AyhamAl-Ali
Copy link
Member

AyhamAl-Ali commented Aug 29, 2021

Can't replicate

command /abc:
	aliases: a
	trigger:
		broadcast "1"	

image

Any errors? does that command say anything when executed? + Send your /sk info

@DieHollanderMC
Copy link
Author

Can't replicate

command /abc:
	aliases: a
	trigger:
		broadcast "1"	

image

Any errors? does that command say anything when executed? + Send your /sk info

Sorry, let me correct myself.
The command does work, but it doesn't register the way it should.
command /test: aliases: testalias trigger: broadcast "a"
https://i.imgur.com/nKxIvTu.png

As you can see, the text color is red, which would mean the command doesn't exist. Though it does execute.

@APickledWalrus
Copy link
Member

Ah, this has to do with how Skript registers its commands. I don't think this is a bug, but more so something that could be improved :)

@DieHollanderMC
Copy link
Author

Ah, this has to do with how Skript registers its commands. I don't think this is a bug, but more so something that could be improved :)

Hm thats a little weird though, because it does show when you just use command /test:

@TPGamesNL TPGamesNL added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: low Issues that are not harmful to the experience but are related to useful changes or additions. labels Aug 29, 2021
@AyhamAl-Ali
Copy link
Member

AyhamAl-Ali commented Aug 29, 2021

As you can see, the text color is red, which would mean the command doesn't exist. Though it does execute.

Oh okay, maybe that's in 1.17 only? it doesn't look red in my 1.16 server with skript 2.6 as you can see in the picture I provided (look the edit below)

Ah, this has to do with how Skript registers its commands. I don't think this is a bug, but more so something that could be improved :)

I remember there was a comment on command aliases registering code to make them register as actual commands to fix such cases but I am not finding it in somehow

EDIT:

Actually no, it's shown as red

command /abc:
	aliases: h
	trigger:
		broadcast "1"

image

@AyhamAl-Ali
Copy link
Member

AyhamAl-Ali commented Aug 29, 2021

Another bug found (actually the original bug):

When I changed the aliases from a to h the command /skript:a still exists in tab completion but when executed gives unknown command error but /skript:h doesn't exists in tab completion but works when executed

but this only happens when you update an existing command, if you create a new command and add aliases it will work as expected even the main topic of this issue will be fixed if used in a new command not updating an existing one. So it is a bug with updating an existing command info.

Another confirmation on what said above:
Created a new command with this alias and it's not shown in red and exists in the tab completion

command /try1:
	aliases: tripletry3
	trigger:
		broadcast "3"

image

@TPGamesNL TPGamesNL changed the title Aliases not working without permission set Aliases not properly updated with server after changing Oct 31, 2021
@APickledWalrus APickledWalrus added the PR available Issues which have a yet-to-be merged PR resolving it label Jun 22, 2022
@APickledWalrus
Copy link
Member

Technically this is a bug, as Skript does not sync commands in many cases where it should. This is one of those cases.

@APickledWalrus APickledWalrus added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. and removed enhancement Feature request, an issue about something that could be improved, or a PR improving something. labels Jul 12, 2022
@APickledWalrus APickledWalrus added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: low Issues that are not harmful to the experience but are related to useful changes or additions.
Projects
None yet
Development

No branches or pull requests

5 participants