Skip to content

Commit e19cbc1

Browse files
committed
- Fix bug where stopping process would cause process output that happened
after the stop request was issued to be lost. See #11. Closes #11.
1 parent 7e4ab0a commit e19cbc1

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

CHANGES.txt

+4
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ Next release
2121
``[supervisord]`` section had no effect. Thanks to Wyatt Baldwin
2222
for a patch.
2323

24+
- Fix bug where stopping process would cause process output that happened
25+
after the stop request was issued to be lost. See
26+
https://github.com/Supervisor/supervisor/issues/11.
27+
2428
3.0a9 (2010-08-13)
2529

2630
- Use rich comparison methods rather than __cmp__ to sort process

src/supervisor/process.py

-1
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,6 @@ def _spawn_as_child(self, filename, argv):
341341

342342
def stop(self):
343343
""" Administrative stop """
344-
self.drain()
345344
self.administrative_stop = 1
346345
return self.kill(self.config.stopsignal)
347346

src/supervisor/tests/test_process.py

-1
Original file line numberDiff line numberDiff line change
@@ -608,7 +608,6 @@ def test_stop(self):
608608
'signal SIGTERM')
609609
self.assertEqual(instance.killing, 1)
610610
self.assertEqual(options.kills[11], signal.SIGTERM)
611-
self.assertEqual(dispatcher.write_event_handled, True)
612611

613612
def test_give_up(self):
614613
options = DummyOptions()

0 commit comments

Comments
 (0)