Skip to content

Consolidate locking mechanisms with stdlib Mutex #3516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
finestructure opened this issue Nov 22, 2024 · 4 comments
Open

Consolidate locking mechanisms with stdlib Mutex #3516

finestructure opened this issue Nov 22, 2024 · 4 comments
Assignees
@finestructure

Comments

@finestructure
Copy link
Member

We're using three different locking mechanisms at the moment, ActorIsolated, LockIsolated, and QueueIsolated. We should use the new standard library Mutex instead.
@finestructure finestructure self-assigned this Nov 22, 2024
@finestructure
Copy link
Member Author

Have to be aware of some pitfalls here, Mutex can apparently crash the compiler on Linux.

https://github.com/swift-server/swift-aws-lambda-runtime/blob/eb634fa9abcd178f9f86852ea0839109bd949a97/Sources/AWSLambdaRuntime/LambdaRuntime.swift#L30

@finestructure
Copy link
Member Author

finestructure commented Mar 15, 2025 •
edited
Loading

See swiftlang/swift#80036 and swiftlang/swift#80020

@sebsto
Copy link

sebsto commented Mar 15, 2025 •
edited
Loading

Looks like the compiler crash happens on Mutex with generic types only
swiftlang/swift#78048

@sebsto
Copy link

sebsto commented Mar 15, 2025

I also think swiftlang/swift#80020 is not related to Mutex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@finestructure finestructure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@finestructure @sebsto