Skip to content

Commit 50e20e1

Browse files
authored
fix(service): properly return cli_version in api version (#3699)
* fix(service): properly return cli_version in api version
1 parent 088ce15 commit 50e20e1

File tree

2 files changed

+36
-15
lines changed

2 files changed

+36
-15
lines changed

renku/ui/service/serializers/version.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ class VersionResponse(Schema):
2121
"""Version response schema."""
2222

2323
latest_version = fields.String()
24+
cli_version = fields.String()
2425
supported_project_version = fields.Integer()
2526
minimum_api_version = fields.String()
2627
maximum_api_version = fields.String()

tests/service/views/test_version_views.py

Lines changed: 35 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,13 @@ def test_version(svc_client):
2626
assert "result" in response.json
2727
data = response.json["result"]
2828

29-
assert {"latest_version", "supported_project_version", "minimum_api_version", "maximum_api_version"} == set(
30-
data.keys()
31-
)
29+
assert {
30+
"latest_version",
31+
"cli_version",
32+
"supported_project_version",
33+
"minimum_api_version",
34+
"maximum_api_version",
35+
} == set(data.keys())
3236
assert __version__ == data["latest_version"]
3337
assert SUPPORTED_PROJECT_VERSION == data["supported_project_version"]
3438
assert MINIMUM_VERSION.name == data["minimum_api_version"]
@@ -38,9 +42,13 @@ def test_version(svc_client):
3842
assert "result" in response.json
3943
data = response.json["result"]
4044

41-
assert {"latest_version", "supported_project_version", "minimum_api_version", "maximum_api_version"} == set(
42-
data.keys()
43-
)
45+
assert {
46+
"latest_version",
47+
"cli_version",
48+
"supported_project_version",
49+
"minimum_api_version",
50+
"maximum_api_version",
51+
} == set(data.keys())
4452
assert __version__ == data["latest_version"]
4553
assert SUPPORTED_PROJECT_VERSION == data["supported_project_version"]
4654
assert MINIMUM_VERSION.name == data["minimum_api_version"]
@@ -50,9 +58,13 @@ def test_version(svc_client):
5058
assert "result" in response.json
5159
data = response.json["result"]
5260

53-
assert {"latest_version", "supported_project_version", "minimum_api_version", "maximum_api_version"} == set(
54-
data.keys()
55-
)
61+
assert {
62+
"latest_version",
63+
"cli_version",
64+
"supported_project_version",
65+
"minimum_api_version",
66+
"maximum_api_version",
67+
} == set(data.keys())
5668
assert __version__ == data["latest_version"]
5769
assert SUPPORTED_PROJECT_VERSION == data["supported_project_version"]
5870
assert MINIMUM_VERSION.name == data["minimum_api_version"]
@@ -62,9 +74,13 @@ def test_version(svc_client):
6274
assert "result" in response.json
6375
data = response.json["result"]
6476

65-
assert {"latest_version", "supported_project_version", "minimum_api_version", "maximum_api_version"} == set(
66-
data.keys()
67-
)
77+
assert {
78+
"latest_version",
79+
"cli_version",
80+
"supported_project_version",
81+
"minimum_api_version",
82+
"maximum_api_version",
83+
} == set(data.keys())
6884
assert __version__ == data["latest_version"]
6985
assert SUPPORTED_PROJECT_VERSION == data["supported_project_version"]
7086
assert MINIMUM_VERSION.name == data["minimum_api_version"]
@@ -74,9 +90,13 @@ def test_version(svc_client):
7490
assert "result" in response.json
7591
data = response.json["result"]
7692

77-
assert {"latest_version", "supported_project_version", "minimum_api_version", "maximum_api_version"} == set(
78-
data.keys()
79-
)
93+
assert {
94+
"latest_version",
95+
"cli_version",
96+
"supported_project_version",
97+
"minimum_api_version",
98+
"maximum_api_version",
99+
} == set(data.keys())
80100
assert __version__ == data["latest_version"]
81101
assert SUPPORTED_PROJECT_VERSION == data["supported_project_version"]
82102
assert MINIMUM_VERSION.name == data["minimum_api_version"]

0 commit comments

Comments
 (0)