Skip to content

Commit d520519

Browse files
authored
[go_router_builder] Tweaks for latest analyzer-6.5.0 (flutter#6632)
This PR slightly tweaks `go_router_builder` to work with `analyzer-6.5.0` and unblock post-submit [errors](https://github.com/flutter/packages/runs/24440595710). ## Issues * Should fix failing tests after this merge: flutter#6631
1 parent 26bd37b commit d520519

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

packages/go_router_builder/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 2.6.1
2+
3+
* Fixes typo in `durationDecoderHelperName`.
4+
* Updates development dependency to `dart_style-2.3.6` (compatible with `analyzer-6.5.0`).
5+
16
## 2.6.0
27

38
* Adds support for passing observers to the StatefulShellBranch for the nested Navigator.

packages/go_router_builder/lib/src/type_helpers.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const String convertMapValueHelperName = r'_$convertMapValue';
1616

1717
/// The name of the generated, private helper for converting [Duration] to
1818
/// [bool].
19-
const String durationDecoderHelperName = r'_$duractionConverter';
19+
const String durationDecoderHelperName = r'_$durationConverter';
2020

2121
/// The name of the generated, private helper for converting [String] to [Enum].
2222
const String enumExtensionHelperName = r'_$fromName';
@@ -91,6 +91,7 @@ String enumMapName(InterfaceType type) => '_\$${type.element.name}EnumMap';
9191

9292
String _stateValueAccess(ParameterElement element, Set<String> pathParameters) {
9393
if (element.isExtraField) {
94+
// ignore: avoid_redundant_argument_values
9495
return 'extra as ${element.type.getDisplayString(withNullability: true)}';
9596
}
9697

packages/go_router_builder/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: go_router_builder
22
description: >-
33
A builder that supports generated strongly-typed route helpers for
44
package:go_router
5-
version: 2.6.0
5+
version: 2.6.1
66
repository: https://github.com/flutter/packages/tree/main/packages/go_router_builder
77
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+go_router_builder%22
88

@@ -23,7 +23,7 @@ dependencies:
2323

2424
dev_dependencies:
2525
build_test: ^2.1.7
26-
dart_style: 2.3.2
26+
dart_style: 2.3.6
2727
flutter:
2828
sdk: flutter
2929
go_router: ^10.0.0

0 commit comments

Comments
 (0)