Skip to content

tests for Hill Cipher algorithm #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matkosoric opened this issue Mar 3, 2020 · 4 comments
Closed

tests for Hill Cipher algorithm #1788

matkosoric opened this issue Mar 3, 2020 · 4 comments
Assignees
@mrvnmchm
Labels
help wanted

Comments

@matkosoric
Copy link
Contributor

tests are missing
@mrvnmchm mrvnmchm self-assigned this Apr 10, 2020
@mrvnmchm mrvnmchm mentioned this issue Apr 13, 2020
Closed
11 tasks
@stale
Copy link

stale bot commented May 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label May 10, 2020
@cclauss cclauss added help wanted and removed stale Used to mark an issue or pull request stale. labels May 10, 2020
@bharath-kotha
Copy link
Contributor

Hey @cclauss and @mrvnmchm. I have seen the PR to fix the issue but seems like it requires some code changes. The code changes have not been made in a long time. Can I take this up and work on the PR?

@cclauss
Copy link
Member

cclauss commented May 15, 2020

#1862 Was another effort but it did not finish so go for it.

@bharath-kotha bharath-kotha mentioned this issue May 17, 2020
Merged
11 tasks
@cclauss
Copy link
Member

cclauss commented Jun 16, 2020

https://github.com/TheAlgorithms/Python/blob/master/ciphers/hill_cipher.py has tests.

@cclauss cclauss closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrvnmchm mrvnmchm

Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests and type hints to hill_cipher.py mrvnmchm/Python
4 participants
@cclauss @mrvnmchm @bharath-kotha @matkosoric