From 5cf9b2f311b67ed3466955c3ba237c3165f2e514 Mon Sep 17 00:00:00 2001 From: Deekshaesha <57080015+Deekshaesha@users.noreply.github.com> Date: Mon, 28 Oct 2019 12:03:37 +0530 Subject: [PATCH 1/3] Update find_max.py --- maths/find_max.py | 22 +++++----------------- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/maths/find_max.py b/maths/find_max.py index 7cc82aacfb09..4036c2f06b6e 100644 --- a/maths/find_max.py +++ b/maths/find_max.py @@ -1,17 +1,5 @@ -# NguyenU - - -def find_max(nums): - max = nums[0] - for x in nums: - if x > max: - max = x - print(max) - - -def main(): - find_max([2, 4, 9, 7, 19, 94, 5]) - - -if __name__ == "__main__": - main() +n = [34,54,56,34,90] +n.sort() +n = set(n) +n = list(n) +print ("Largest number : ",l[-1]) From 5001359eaf46b0d7323988f18c7847bb4593f724 Mon Sep 17 00:00:00 2001 From: Deekshaesha <57080015+Deekshaesha@users.noreply.github.com> Date: Mon, 28 Oct 2019 13:17:17 +0530 Subject: [PATCH 2/3] Update find_max.py --- maths/find_max.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/maths/find_max.py b/maths/find_max.py index 4036c2f06b6e..10bb42abc972 100644 --- a/maths/find_max.py +++ b/maths/find_max.py @@ -1,5 +1,5 @@ -n = [34,54,56,34,90] +n = [34, 54, 56, 90] n.sort() n = set(n) n = list(n) -print ("Largest number : ",l[-1]) +print("Largest number : ", n[len(n)-2]) From 8efac7fb04ac2f008a9acbfbcee9ef32dc42438a Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Mon, 28 Oct 2019 09:14:35 +0100 Subject: [PATCH 3/3] Format with psf/black and add doctests --- maths/find_max.py | 30 +++++++++++++++++++++++++----- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/maths/find_max.py b/maths/find_max.py index 10bb42abc972..8b5ab48e6185 100644 --- a/maths/find_max.py +++ b/maths/find_max.py @@ -1,5 +1,25 @@ -n = [34, 54, 56, 90] -n.sort() -n = set(n) -n = list(n) -print("Largest number : ", n[len(n)-2]) +# NguyenU + + +def find_max(nums): + """ + >>> for nums in ([3, 2, 1], [-3, -2, -1], [3, -3, 0], [3.0, 3.1, 2.9]): + ... find_max(nums) == max(nums) + True + True + True + True + """ + max = nums[0] + for x in nums: + if x > max: + max = x + return max + + +def main(): + print(find_max([2, 4, 9, 7, 19, 94, 5])) # 94 + + +if __name__ == "__main__": + main()