Skip to content

DIRECTORY.md is out of date #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CSRessel opened this issue Oct 25, 2023 · 9 comments
Closed

DIRECTORY.md is out of date #591

CSRessel opened this issue Oct 25, 2023 · 9 comments

Comments

@CSRessel
Copy link
Contributor

Algorithms and their links are missing from the DIRECTORY.md file. I can add these in a PR after comparing the contents of each directory, and I'd also like to update the PR checklist to include this update step so that it's less likely to be forgotten in the future.

@siriak
Copy link
Member

siriak commented Oct 25, 2023

There is a workflow that should be updating DIRECTORY, but it fails with access issues, could you look into that? Updating it manually is not sustainable. Let's keep this issue open so that maybe it's fixed at some point :)

@CSRessel
Copy link
Contributor Author

Great suggestion, I was thinking it would be nice to automate but I see what you mean; there's already a script in the workflows for that. I'll take a look into that!

@CSRessel CSRessel mentioned this issue Oct 31, 2023
8 tasks
@CSRessel
Copy link
Contributor Author

@siriak I think that between when the directory workflow was created and now, additional branch protections have likely been added. However, since I can't see the repo settings/branch protections, a little help would be needed! I have a proposed solution here: #596

If you take a look, can you let me know if that looks feasible with what you're seeing in the branch protections? Or if I'm referencing options that aren't appearing there. And I'll leave that PR as WIP until you confirm that it seems like a working solution for the workflow permissions

Thanks for your help!

@siriak
Copy link
Member

siriak commented Oct 31, 2023

Sorry, I didn't have time to check today. I'll do it tomorrow or in a few days.

@siriak
Copy link
Member

siriak commented Nov 1, 2023

Let's keep the discussion in #596

Copy link

github-actions bot commented Dec 2, 2023

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 2, 2023
@CSRessel
Copy link
Contributor Author

CSRessel commented Dec 4, 2023

Bump, I'm taking one more stab at this problem in case it can be addressed with deploy keys

@siriak siriak removed the stale label Dec 4, 2023
@CSRessel
Copy link
Contributor Author

I think this is probably good to close! Given that the associated PR merge automatically updated the directory as anticipated: d1ffaa2

@siriak
Copy link
Member

siriak commented Dec 23, 2023

Thanks, @CSRessel!

@siriak siriak closed this as completed Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants