-
Notifications
You must be signed in to change notification settings - Fork 433
Support for 404 Status Code #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@MarkPieszak did you plan on doing this in engine? |
Must-have functionality for production use with SEO, voting up. 1) Set
2) Parse
3) Apply
|
With new Angular CLI based template (aspnet/JavaScriptServices#1288 (comment)), we would need different approach. I have an open issue at aspnet/JavaScriptServices#1423 |
There should also be a support for setting proper status code especially in case of 404 not found errors.
I have seen some discussion about setting status codes here:
angular/universal#667
And the service referred by @patrickmichalina seems awesome.
https://github.com/patrickmichalina/fusebox-angular-universal-starter/blob/master/src/client/app/shared/services/server-response.service.ts
To add its support I think it would require update to aspnetcore-engine.
@MarkPieszak @isaac2004
The text was updated successfully, but these errors were encountered: