Skip to content

Combine Condition and FixedContext? #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
penelopeysm opened this issue Apr 17, 2025 · 1 comment
Open

Combine Condition and FixedContext? #894

penelopeysm opened this issue Apr 17, 2025 · 1 comment

Comments

@penelopeysm
Copy link
Member

penelopeysm commented Apr 17, 2025 •
edited
Loading

There's a ton of code duplication between the two. Is there a way to combine them? My guess is probably not*, but it would be nice to try.

* Not without doing some nasty @eval stuff, which I don't want to do.
@yebai
Copy link
Member

yebai commented Apr 18, 2025

This should be possible after #744 since the only difference between condition and fix is whether to accumulate logp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yebai @penelopeysm