Skip to content

Commit 3aa526b

Browse files
authored
Update FillArrays compat to 1.4.1 (#2035)
* Update FillArrays compat to 1.4.0 * Update test compat * Try to enable ReverseDiff tests * Update Project.toml * Update Project.toml
1 parent 408dfcd commit 3aa526b

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

Diff for: Project.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ DistributionsAD = "0.6"
5151
DocStringExtensions = "0.8, 0.9"
5252
DynamicPPL = "0.23"
5353
EllipticalSliceSampling = "0.5, 1"
54-
FillArrays = "=1.0.0"
54+
FillArrays = "1.4.1"
5555
ForwardDiff = "0.10.3"
5656
Libtask = "0.7, 0.8"
5757
LogDensityProblems = "2"

Diff for: test/Project.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Distributions = "0.25"
4242
DistributionsAD = "0.6.3"
4343
DynamicHMC = "2.1.6, 3.0"
4444
DynamicPPL = "0.23"
45-
FillArrays = "=1.0.0"
45+
FillArrays = "1.4.1"
4646
FiniteDifferences = "0.10.8, 0.11, 0.12"
4747
ForwardDiff = "0.10.12 - 0.10.32, 0.10"
4848
LogDensityProblems = "2"

Diff for: test/essential/ad.jl

+4-5
Original file line numberDiff line numberDiff line change
@@ -95,15 +95,14 @@
9595
sample(dir(), HMC(0.01, 1), 1000)
9696
Turing.setrdcache(false)
9797
end
98-
# FIXME: For some reasons PDMatDistribution AD tests fail with ReverseDiff
9998
@testset "PDMatDistribution AD" begin
10099
@model function wishart()
101100
theta ~ Wishart(4, Matrix{Float64}(I, 4, 4))
102101
end
103102
Turing.setadbackend(:tracker)
104103
sample(wishart(), HMC(0.01, 1), 1000);
105-
#Turing.setadbackend(:reversediff)
106-
#sample(wishart(), HMC(0.01, 1), 1000);
104+
Turing.setadbackend(:reversediff)
105+
sample(wishart(), HMC(0.01, 1), 1000);
107106
Turing.setadbackend(:zygote)
108107
sample(wishart(), HMC(0.01, 1), 1000);
109108

@@ -112,8 +111,8 @@
112111
end
113112
Turing.setadbackend(:tracker)
114113
sample(invwishart(), HMC(0.01, 1), 1000);
115-
#Turing.setadbackend(:reversediff)
116-
#sample(invwishart(), HMC(0.01, 1), 1000);
114+
Turing.setadbackend(:reversediff)
115+
sample(invwishart(), HMC(0.01, 1), 1000);
117116
Turing.setadbackend(:zygote)
118117
sample(invwishart(), HMC(0.01, 1), 1000);
119118
end

0 commit comments

Comments
 (0)