Skip to content
This repository was archived by the owner on Mar 22, 2024. It is now read-only.

Indicate that parser.javascript.url: true is necessary for wasm load #3

Closed
jhk-mjolner opened this issue Sep 12, 2023 · 3 comments · Fixed by #4
Closed

Indicate that parser.javascript.url: true is necessary for wasm load #3

jhk-mjolner opened this issue Sep 12, 2023 · 3 comments · Fixed by #4

Comments

@jhk-mjolner
Copy link
Contributor

jhk-mjolner commented Sep 12, 2023

In the example webpack config there's a few lines that supposed fixes a 'ttf url loading issue':

// this fixes the ttf url loading issue
parser: {
javascript: {
url: true
}
}

I can attest (CodinGame/monaco-vscode-api#186) that since monaco-languageclient 6.3.0 and monaco-vscode-api 1.80.0 it is also necessary to be able to load the vscode wasm file, and some theme .json files too.

It might not seem like much, but I suggest at least updating the comment to indicate that those lines are now vitally important to be able to load vscode properly, as I had not included the lines in my webpack config, as they seemed to be for a problem I didn't have.

@kaisalmen
Copy link
Collaborator

@jhk-mjolner thanks for reporting. As said in the other issue help is appreciated.
Otherwise, I am planning to update this with next larger update cycle.

@jhk-mjolner
Copy link
Contributor Author

I'm not sure how much it makes sense to include in the updated comment, but it could include links to https://stackoverflow.com/questions/74038161/angular-cli-and-loading-assets-with-import-meta-url-causing-not-allowed-to-load and angular/angular-cli#24617 for context.

I don't mind it taking a little while to be updated, as just having these two issues exist might be enough to help the next person with the problem.

@kaisalmen
Copy link
Collaborator

@jhk-mjolner I will see what's needed when I get to it. 😆 What you found is already very helpful and will help me fix things when updating the deps/config here. I will include any helpful links directly the config.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants