Sending configuration options

[jtokoph]

Is there an example of sending configuration options to the language server? For example, I'd like to be able to send a list of plugin options to the python language server. In vscode, it uses the synchronize option to send vscode config values. How would I go about manually sending config values from the monaco-language client?

These are the options I want to be able to send: https://github.com/palantir/python-language-server/blob/develop/vscode-client/package.json#L19

[akosyakov]

@jtokoph The monaco-languageclient is abstracted away from VS code via services, e.g. Workspace service provides an access to configurations which are used by the language client.
https://github.com/TypeFox/vscode-languageserver-node/blob/9449b41d27e4ffb0d72c1f5a85c47d1beead6073/client/src/services.ts#L144-L163

By the default, the subset of the services is implemented to support the standalone editor. You have to subclass MonacoWorkspace and provide support for configurations.

monaco-languageclient/src/workspace.ts

Line 11 in b901301

export class MonacoWorkspace implements Workspace {

[akosyakov]

We could also pass an instance of Configurations to MonacoWorkspace via options (depends on #31). And provide the default InMemoryConfigurations implementation.

[akosyakov]

PRs are welcomed. @jtokoph feel free to look into it

[cdietrich]

#31 is done now

[SamVerschueren]

@jtokoph Is there a workaround for now? Also struggling with the python language server.

[SamVerschueren]

I managed to get this working by implementing my own configuration class.

class WorkspaceConfiguration {
	constructor(
		config: any
	) {
		for (const key of Object.keys(config || {})) {
			this[key] = config[key];
		}
	}

	get<T>(section: string, defaultValue?: T) {
		console.log(this);
		return this[section] || defaultValue;
	}
}


class Configuration {
	private onConfigChanged: Function = () => {};

	getConfiguration(section?: string) {
		return new WorkspaceConfiguration(this[section]);
	}

	update(section: string, value: any, configurationTarget?: any) {
		this[section] = value;

		this.onConfigChanged();
	}

	onDidChangeConfiguration(cb: Function) {
		this.onConfigChanged = cb;
	}
}

After that, you can set the workspace.configurations object.

const config = new Configuration();

// create and start the language client
const languageClient = createLanguageClient(connection);
(languageClient.workspace as any).configurations = config;

config.update('pyls', {
	plugins: {
		pydocstyle: {
			enabled: false
		}
	}
});

If I find some time, and you are interested, I can do a PR.

[akosyakov]

@SamVerschueren feel free to open the PR

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.