Skip to content

[hyperclick] stop scanning .js files #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AsaAyers opened this issue Sep 2, 2016 · 1 comment
Closed

[hyperclick] stop scanning .js files #1062

AsaAyers opened this issue Sep 2, 2016 · 1 comment

Comments

@AsaAyers
Copy link
Contributor

AsaAyers commented Sep 2, 2016

I have a package called js-hyperclick and I have to tell users to disable atom-typescript if they want to use js-hyperclick. The hyperclick service asks each registered package in order to scan a file and the first package that returns a result wins.

Your getSuggestionForWord implementation returns a match whether it's really a match or not, and then only does the work necessary in the callback. Because it always returns a value hyperclick will never call js-hyperclick.

@tungv
Copy link

tungv commented Sep 23, 2016

yeah, I wish I wouldn't need to uninstall atom-typescript, but I can't live without js-hyperclick

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants