Skip to content

Autocomplete for object destructuring in arrow function is bugged #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
senyaak opened this issue Dec 19, 2019 · 4 comments
Closed

Autocomplete for object destructuring in arrow function is bugged #1528

senyaak opened this issue Dec 19, 2019 · 4 comments

Comments

@senyaak
Copy link

senyaak commented Dec 19, 2019

For example we have following code

([{a:1},{a:2},{a:3}] as {a: number}[]).forEach(({})=>null);

If you place pointer between '{' and '}' and then hit alt+space - autocomplete breaks the function.
What I expect

([{a:1},{a:2},{a:3}] as {a: number}[]).forEach(({a})=>null);

What I get

([{a:1},{a:2},{a:3}] as {a: number}[]).forEacha})=>null);

PS
Atom 1.41.0
Atom-Typescript 13.4.0

@lierdakil
Copy link
Collaborator

Thanks for reporting! Should be fixed in v13.4.1.

@senyaak
Copy link
Author

senyaak commented Dec 19, 2019

Thank you for quick fix! @lierdakil
But unfortunately there some bug in fix. Console says:
Uncaught (in promise) Error: Cannot find module './misc'

@lierdakil
Copy link
Collaborator

Huh. Ouch. Yup, sorry, that was my bad. Hopefully fixed in v13.4.3

@lierdakil
Copy link
Collaborator

Augh. Sorry, found another issue with the new implementation, when prefix with mismatched case wouldn't be replaced. v13.4.4 should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants