Skip to content

Improve noEmitOnError experience #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
basarat opened this issue Sep 22, 2015 · 0 comments
Closed

Improve noEmitOnError experience #603

basarat opened this issue Sep 22, 2015 · 0 comments
Labels
category:performance stale up-for-grabs

Comments

@basarat
Copy link
Member

basarat commented Sep 22, 2015

Currently build is horribly slow for noEmitOnError.

  • A short term measure in atom-typescript would be to abort the build with an error if noEmitOnError is set, rather than building the project very very slowly (and hanging the background worker for any useful work for upto 3 mintues!)
  • Long term : Investigate the language service to find a function that gets all the emits for the files in a single validation instead of a revalidating -> emitting step per file.

/cc @robertknight
refs #590 (comment) and microsoft/TypeScript#4894 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category:performance stale up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@basarat @lierdakil