Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsconfig.json always save to CRLF on Windows environment #678

Closed
stan0227 opened this issue Oct 22, 2015 · 3 comments · Fixed by #889
Closed

tsconfig.json always save to CRLF on Windows environment #678

stan0227 opened this issue Oct 22, 2015 · 3 comments · Fixed by #889

Comments

@stan0227
Copy link

Atom Editor now has line ending selector for selecting ending format of file.

But on Windows environment even I try to select LF format for tsconfig.json which always be saved to CRLF format.

Does it have limitation to solve the issue? Thanks a lot!

@blakeembrey
Copy link
Member

Looks like it's currently done intentionally and can't be changed (https://github.com/TypeStrong/atom-typescript/blob/master/dist/main/tsconfig/tsconfig.js#L422). The fix here would be to detect the current line endings, like we do with indent, and stringify it back the same.

@basarat
Copy link
Member

basarat commented Oct 23, 2015

Also the setting needs to be sent from the front end process to the backend process (which is the main reason it hasn't been done yet)

@slikts
Copy link

slikts commented Nov 2, 2015

The fix here would be to detect the current line endings, like we do with indent, and stringify it back the same.

Using a separate file instead of tsconfig.json would be even better, especially since TS now supports comments in tsconfig.json.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants