Skip to content

Commit bbe953f

Browse files
committed
get rid of clip imput on node
1 parent 0c7dac1 commit bbe953f

File tree

3 files changed

+4
-12
lines changed

3 files changed

+4
-12
lines changed

com.unity.sg2/Documentation~/Imposter-Sample-Node.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ If the imposter object has more than one texture to sample (e.g. color, normal,
1616
| UV2 | Input | Vector4 | The virtual UV for the third frame |
1717
| Grid | Input | Vector4 | The current UV grid, which is used to find the corresponding sample frames |
1818
| Frames | Input | Float | The number of the imposter frames in each axis|
19-
| Clip | Input | Float | The amount of clipping for a single frame |
2019
| Parallax | Input | Float | Parallax strength|
2120
| Height Map Channel | Input | Int | The channle of the height map to sample for parallax mapping, if any|
2221
| RGBA | Output | Vector3 | A vector4 from the sampled texture |
@@ -57,11 +56,11 @@ The Imposter Sample Node [!include[nodes-controls](./snippets/nodes-controls.md)
5756
### ThreeFrames
5857

5958
```
60-
ImposterSample(HeightMapChannel, ViewDirectionTS, Parallax, Frames, Texture.tex, Texture.texelSize, Clip, Grid, UV0, UV1, UV2, Sampler.samplerstate, RGBA);
59+
ImposterSample(HeightMapChannel, ViewDirectionTS, Parallax, Frames, Texture.tex, Texture.texelSize, Grid, UV0, UV1, UV2, Sampler.samplerstate, RGBA);
6160
```
6261

6362
### OneFrame
6463

6564
```
66-
ImposterSample_oneFrame(HeightMapChannel, ViewDirectionTS, Parallax, Frames, Texture.tex, Texture.texelSize, Clip, Grid, UV0, Sampler.samplerstate, RGBA);
65+
ImposterSample_oneFrame(HeightMapChannel, ViewDirectionTS, Parallax, Frames, Texture.tex, Texture.texelSize, Grid, UV0, Sampler.samplerstate, RGBA);
6766
```

com.unity.sg2/Documentation~/previews/ImposterSample.md

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ This creates the illusion of a 3D object on a billboard object because the impos
1010
**UV2** - The virtual UV for the third frame.
1111
**Grid** - The current UV grid, which is used to find the corresponding sample frames.
1212
**Frames** - The number of the imposter frames in each axis.
13-
**Clip** - The amount of clipping for a single frame.
1413
**Parallax** - Parallax strength.
1514
**Height Map Channel** - The channle of the height map to sample for parallax mapping, if any.
1615

com.unity.sg2/Editor/GraphDeltaRegistry/FunctionDefinitions/StandardDefinitions/Input/MeshDeformation/ImposterSampleNode.cs

+2-8
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ internal class ImposterSampleNode : IStandardNode
1414
functions: new FunctionDescriptor[] {
1515
new(
1616
"ThreeFrames",
17-
@"ImposterSample(HeightMapChannel, ViewDirectionTS, Parallax, Frames, Texture.tex, Texture.texelSize, Clip, Grid, UV0, UV1, UV2, Sampler.samplerstate, RGBA);",
17+
@"ImposterSample(HeightMapChannel, ViewDirectionTS, Parallax, Frames, Texture.tex, Texture.texelSize, Grid, UV0, UV1, UV2, Sampler.samplerstate, RGBA);",
1818
new ParameterDescriptor[]
1919
{
2020
new ParameterDescriptor("Texture", TYPE.Texture2D, Usage.In),
@@ -24,7 +24,6 @@ internal class ImposterSampleNode : IStandardNode
2424
new ParameterDescriptor("UV2", TYPE.Vec4, Usage.In),
2525
new ParameterDescriptor("Grid", TYPE.Vec4, Usage.In),
2626
new ParameterDescriptor("Frames", TYPE.Float, Usage.In, new float[] {16f}),
27-
new ParameterDescriptor("Clip", TYPE.Float, Usage.In, new float[] {1f}),
2827
new ParameterDescriptor("Parallax", TYPE.Float, Usage.In),
2928
new ParameterDescriptor("ViewDirectionTS", TYPE.Vec3, Usage.Local, REF.TangentSpace_ViewDirection),
3029
new ParameterDescriptor("HeightMapChannel", TYPE.Int, Usage.In, 3),
@@ -37,15 +36,14 @@ internal class ImposterSampleNode : IStandardNode
3736
),
3837
new(
3938
"OneFrame",
40-
@"ImposterSample_oneFrame(HeightMapChannel, ViewDirectionTS, Parallax, Frames, Texture.tex, Texture.texelSize, Clip, Grid, UV0, Sampler.samplerstate, RGBA);",
39+
@"ImposterSample_oneFrame(HeightMapChannel, ViewDirectionTS, Parallax, Frames, Texture.tex, Texture.texelSize, Grid, UV0, Sampler.samplerstate, RGBA);",
4140
new ParameterDescriptor[]
4241
{
4342
new ParameterDescriptor("Texture", TYPE.Texture2D, Usage.In),
4443
new ParameterDescriptor("Sampler", TYPE.SamplerState, Usage.In),
4544
new ParameterDescriptor("UV0", TYPE.Vec4, Usage.In),
4645
new ParameterDescriptor("Grid", TYPE.Vec4, Usage.In),
4746
new ParameterDescriptor("Frames", TYPE.Float, Usage.In, new float[] {16f}),
48-
new ParameterDescriptor("Clip", TYPE.Float, Usage.In, new float[] {1f}),
4947
new ParameterDescriptor("Parallax", TYPE.Float, Usage.In),
5048
new ParameterDescriptor("ViewDirectionTS", TYPE.Vec3, Usage.Local, REF.TangentSpace_ViewDirection),
5149
new ParameterDescriptor("HeightMapChannel", TYPE.Int, Usage.In, 3),
@@ -103,10 +101,6 @@ internal class ImposterSampleNode : IStandardNode
103101
name: "Frames",
104102
tooltip: "The amount of the imposter frames"
105103
),
106-
new ParameterUIDescriptor(
107-
name: "Clip",
108-
tooltip: "The amount of clipping for a single frame"
109-
),
110104
new ParameterUIDescriptor(
111105
name: "Parallax",
112106
tooltip: "Adds parallax effect the port value is true"

0 commit comments

Comments
 (0)