Skip to content

Commit 61a2d0d

Browse files
fix: Stop checking hierarchy changed in playmode (#3026)
* fix stop checking for hierarchy changes when we enter into play mode. * update adding changelog entry * style fixing spelling mistake. * update adding PR number to changelog entry.
1 parent 1b900a4 commit 61a2d0d

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

com.unity.netcode.gameobjects/CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ Additional documentation and release notes are available at [Multiplayer Documen
1212

1313
### Fixed
1414

15+
- Fixed issue where the `NetworkManagerHelper` was continuing to check for hierarchy changes when in play mode. (#3026)
16+
1517
### Changed
1618

1719
## [2.0.0-pre.4] - 2024-08-21

com.unity.netcode.gameobjects/Editor/NetworkManagerHelper.cs

+12
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,12 @@ private static void EditorApplication_playModeStateChanged(PlayModeStateChange p
6161
{
6262
s_LastKnownNetworkManagerParents.Clear();
6363
ScenesInBuildActiveSceneCheck();
64+
EditorApplication.hierarchyChanged -= EditorApplication_hierarchyChanged;
65+
break;
66+
}
67+
case PlayModeStateChange.EnteredEditMode:
68+
{
69+
EditorApplication.hierarchyChanged += EditorApplication_hierarchyChanged;
6470
break;
6571
}
6672
}
@@ -110,6 +116,12 @@ private static void ScenesInBuildActiveSceneCheck()
110116
/// </summary>
111117
private static void EditorApplication_hierarchyChanged()
112118
{
119+
if (Application.isPlaying)
120+
{
121+
EditorApplication.hierarchyChanged -= EditorApplication_hierarchyChanged;
122+
return;
123+
}
124+
113125
var allNetworkManagers = Resources.FindObjectsOfTypeAll<NetworkManager>();
114126
foreach (var networkManager in allNetworkManagers)
115127
{

0 commit comments

Comments
 (0)