test - fix

Fixing an issue where it was possible for the NetworkVisibility test to fail if it didn't wait long enough for the message to be processed and the player id removed from the NetworkSpawnManager.ObjectsToShowToClient table.

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Tests/Runtime/NetworkVisibilityTests.cs

@@ -87,8 +87,9 @@ public IEnumerator HideShowAndDeleteTest()
             sessionOwnerNetworkObject.NetworkShow(m_ClientNetworkManagers[clientIndex].LocalClientId);
             sessionOwnerNetworkObject.Despawn(true);
 
-            // Expect no exceptions
-            yield return s_DefaultWaitForTick;
+            // Expect no exceptions while waiting to show the object and wait for the client id to be removed
+            yield return WaitForConditionOrTimeOut(() => !m_SessionOwner.SpawnManager.ObjectsToShowToClient.ContainsKey(m_ClientNetworkManagers[clientIndex].LocalClientId));
+            AssertOnTimeout($"Timed out waiting for client-{m_ClientNetworkManagers[clientIndex].LocalClientId} to be removed from the {nameof(NetworkSpawnManager.ObjectsToShowToClient)} table!");
 
             // Now force a scenario where it normally would have caused an exception
             m_SessionOwner.SpawnManager.ObjectsToShowToClient.Add(m_ClientNetworkManagers[clientIndex].LocalClientId, new System.Collections.Generic.List<NetworkObject>());