Skip to content

Commit b613bfa

Browse files
fix: adding extended timeout to all universal rpc tests (#3170)
fix Adding extended timeout to all universal rpc tests
1 parent 5a9db6d commit b613bfa

File tree

1 file changed

+17
-5
lines changed

1 file changed

+17
-5
lines changed

com.unity.netcode.gameobjects/Tests/Runtime/UniversalRpcTests.cs

+17-5
Original file line numberDiff line numberDiff line change
@@ -918,6 +918,7 @@ public void RethrowTargetInvocationException(Action action)
918918
}
919919
}
920920

921+
[Timeout(1200000)]
921922
[TestFixture(HostOrServer.Host)]
922923
[TestFixture(HostOrServer.Server)]
923924
internal class UniversalRpcTestSendingNoOverride : UniversalRpcTestsBase
@@ -948,6 +949,7 @@ public void TestSendingNoOverride(
948949

949950
}
950951

952+
[Timeout(1200000)]
951953
[TestFixture(HostOrServer.Host)]
952954
[TestFixture(HostOrServer.Server)]
953955
internal class UniversalRpcTestSenderClientId : UniversalRpcTestsBase
@@ -978,6 +980,7 @@ public void TestSenderClientId(
978980

979981
}
980982

983+
[Timeout(1200000)]
981984
[TestFixture(HostOrServer.Host)]
982985
[TestFixture(HostOrServer.Server)]
983986
internal class UniversalRpcTestSendingNoOverrideWithParams : UniversalRpcTestsBase
@@ -1020,6 +1023,7 @@ public void TestSendingNoOverrideWithParams(
10201023

10211024
}
10221025

1026+
[Timeout(1200000)]
10231027
[TestFixture(HostOrServer.Host)]
10241028
[TestFixture(HostOrServer.Server)]
10251029
internal class UniversalRpcTestSendingNoOverrideWithParamsAndRpcParams : UniversalRpcTestsBase
@@ -1062,6 +1066,7 @@ public void TestSendingNoOverrideWithParamsAndRpcParams(
10621066

10631067
}
10641068

1069+
[Timeout(1200000)]
10651070
[TestFixture(HostOrServer.Host)]
10661071
[TestFixture(HostOrServer.Server)]
10671072
internal class UniversalRpcTestRequireOwnership : UniversalRpcTestsBase
@@ -1098,6 +1103,7 @@ public void TestRequireOwnership(
10981103
}
10991104
}
11001105

1106+
[Timeout(1200000)]
11011107
[TestFixture(HostOrServer.Host)]
11021108
[TestFixture(HostOrServer.Server)]
11031109
internal class UniversalRpcTestDisallowedOverride : UniversalRpcTestsBase
@@ -1133,6 +1139,7 @@ public void TestDisallowedOverride(
11331139

11341140
}
11351141

1142+
[Timeout(1200000)]
11361143
[TestFixture(HostOrServer.Host)]
11371144
[TestFixture(HostOrServer.Server)]
11381145
internal class UniversalRpcTestSendingWithTargetOverride : UniversalRpcTestsBase
@@ -1166,6 +1173,7 @@ public void TestSendingWithTargetOverride(
11661173

11671174
}
11681175

1176+
[Timeout(1200000)]
11691177
[TestFixture(HostOrServer.Host)]
11701178
[TestFixture(HostOrServer.Server)]
11711179
internal class UniversalRpcTestSendingWithSingleOverride : UniversalRpcTestsBase
@@ -1213,6 +1221,7 @@ public IEnumerator TestSendingWithSingleOverride()
12131221

12141222
}
12151223

1224+
[Timeout(1200000)]
12161225
[TestFixture(HostOrServer.Host)]
12171226
[TestFixture(HostOrServer.Server)]
12181227
internal class UniversalRpcTestSendingWithSingleNotOverride : UniversalRpcTestsBase
@@ -1261,7 +1270,7 @@ public IEnumerator TestSendingWithSingleNotOverride()
12611270
}
12621271

12631272
[Timeout(1200000)]
1264-
[TestFixture(HostOrServer.Host)]
1273+
[TestFixture(HostOrServer.Host)]
12651274
[TestFixture(HostOrServer.Server)]
12661275
internal class UniversalRpcTestSendingWithGroupOverride : UniversalRpcTestsBase
12671276
{
@@ -1288,7 +1297,6 @@ public enum AllocationType
12881297

12891298
// Extending timeout since the added yield return causes this test to commonly timeout
12901299
[Test]
1291-
[Ignore("Test Needs Refactor")]
12921300
public void TestSendingWithGroupOverride(
12931301
[Values] SendTo defaultSendTo,
12941302
[ValueSource(nameof(RecipientGroups))] ulong[] recipient,
@@ -1339,7 +1347,7 @@ [Values] AllocationType allocationType
13391347
}
13401348
}
13411349

1342-
1350+
13431351
[Timeout(1200000)]
13441352
[TestFixture(HostOrServer.Host)]
13451353
[TestFixture(HostOrServer.Server)]
@@ -1366,10 +1374,9 @@ public enum AllocationType
13661374
List
13671375
}
13681376

1369-
1377+
13701378
// Extending timeout since the added yield return causes this test to commonly timeout
13711379
[Test]
1372-
[Ignore("Test Needs Refactor")]
13731380
public void TestSendingWithGroupNotOverride(
13741381
[Values] SendTo defaultSendTo,
13751382
[ValueSource(nameof(RecipientGroups))] ulong[] recipient,
@@ -1420,6 +1427,7 @@ [Values] AllocationType allocationType
14201427
}
14211428
}
14221429

1430+
[Timeout(1200000)]
14231431
[TestFixture(HostOrServer.Host)]
14241432
[TestFixture(HostOrServer.Server)]
14251433
internal class UniversalRpcTestDefaultSendToSpecifiedInParamsSendingToServerAndOwner : UniversalRpcTestsBase
@@ -1430,6 +1438,7 @@ public UniversalRpcTestDefaultSendToSpecifiedInParamsSendingToServerAndOwner(Hos
14301438
}
14311439
}
14321440

1441+
[Timeout(1200000)]
14331442
[TestFixture(HostOrServer.Host)]
14341443
[TestFixture(HostOrServer.Server)]
14351444
internal class UniversalRpcTestDeferLocal : UniversalRpcTestsBase
@@ -1617,6 +1626,7 @@ public IEnumerator TestDeferLocalOverrideToFalse()
16171626

16181627
}
16191628

1629+
[Timeout(1200000)]
16201630
[TestFixture(HostOrServer.Host)]
16211631
[TestFixture(HostOrServer.Server)]
16221632
internal class UniversalRpcTestMutualRecursion : UniversalRpcTestsBase
@@ -1666,6 +1676,7 @@ public void TestMutualRecursion()
16661676

16671677
}
16681678

1679+
[Timeout(1200000)]
16691680
[TestFixture(HostOrServer.Host)]
16701681
[TestFixture(HostOrServer.Server)]
16711682
internal class UniversalRpcTestSelfRecursion : UniversalRpcTestsBase
@@ -1705,6 +1716,7 @@ public void TestSelfRecursion()
17051716

17061717
}
17071718

1719+
[Timeout(1200000)]
17081720
[TestFixture(ObjType.Server)]
17091721
[TestFixture(ObjType.Client)]
17101722
internal class UniversalRpcTestRpcTargetUse : UniversalRpcTestsBase

0 commit comments

Comments
 (0)