Develop deprecate python 3.6 (#5)

* Dropped support for python 3.6

* Pinning python 3.9.9 for tests due to typing issues with 3.9.10

* Testing new bokken image.

* Testing new bokken image.

* Updated yamato standalone build test.

* Updated yamato standalone build test.

* Updated standalone build test.

* Updated yamato configs to use mla bokken vm.

* Bug fixes for yamato yml files.

* Fixed com.unity.ml-agents-test.yml

* Bumped min python version to 3.7.2

* Updated failing yamato jobs.

* Updated github workflow for colab tests.

* Updated github workflow for colab tests.

* Updated github workflow for colab tests.

Author: miguelalonsojr

.github/workflows/colab.yml

@@ -30,7 +30,7 @@ jobs:
     - name: Set up Python
       uses: actions/setup-python@v2
       with:
-        python-version: 3.8.x
+        python-version: 3.9.9
     - uses: actions/setup-dotnet@v1
       with:
         dotnet-version: '6.0.x'

.github/workflows/pytest.yml

@@ -24,14 +24,11 @@ jobs:
       # If one test in the matrix fails we still want to run the others.
       fail-fast: false
       matrix:
-        # NOTE: 3.9.10 was failing but is hard to test since it JUST came out. Delaying debugging for now.
-        # TODO: Set back to 3.9.x once we can test with 3.9.10 via pyenv.
-        python-version: [3.6.x, 3.7.x, 3.8.x, 3.9.9]
+        # pinning python 3.9.9 since there are typing issues with 3.9.10: https://github.com/Unity-Technologies/ml-agents/issues/5689
+        python-version: [3.7.x, 3.8.x, 3.9.9]
         include:
-          - python-version: 3.6.x
-            pip_constraints: test_constraints_min_version.txt
           - python-version: 3.7.x
-            pip_constraints: test_constraints_mid_version.txt
+            pip_constraints: test_constraints_min_version.txt
           - python-version: 3.8.x
             pip_constraints: test_constraints_mid_version.txt
           - python-version: 3.9.9

.yamato/com.unity.ml-agents-coverage.yml

@@ -14,7 +14,9 @@ test_coverage_{{ package.name }}_{{ platform.name }}_{{ editor.version }}:
     commands:
         - npm install upm-ci-utils@stable -g --registry https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm
         - upm-ci project test -u {{ editor.version }} --type project-tests --project-path {{ editor.testProject }} --package-filter {{ package.name }} {{ coverageOptions }} --extra-utr-arg "reruncount=2"
-        - python3 ml-agents/tests/yamato/check_coverage_percent.py upm-ci~/test-results/ {{ package.minCoveragePct }}
+        - |
+          conda activate python3.7
+          python3 ml-agents/tests/yamato/check_coverage_percent.py upm-ci~/test-results/ {{ package.minCoveragePct }}
     artifacts:
         logs:
             paths:

.yamato/com.unity.ml-agents-optional-dep-tests.yml

@@ -15,7 +15,7 @@ OptionalDependencyTests_{{ optional_dep.name }}:
     name : Test Optional Package Dependencies {{ optional_dep.name }}
     agent:
         type: Unity::VM
-        image: package-ci/ubuntu:stable
+        image: ml-agents/ml-agents-ubuntu-18.04:latest
         flavor: b1.medium
     commands:
         - |

.yamato/com.unity.ml-agents-pack.yml

@@ -2,10 +2,12 @@ pack:
   name: Pack
   agent:
     type: Unity::VM
-    image: package-ci/ubuntu:stable
+    image: ml-agents/ml-agents-ubuntu-18.04:latest
     flavor: b1.small
   commands:
     - |
+      eval "$($HOME/anaconda/bin/conda shell.bash hook)"
+      conda activate python3.7
       python3 -m pip install unity-downloader-cli --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple --upgrade
       unity-downloader-cli -u 2020.3 -c editor --wait --fast
       ./.Editor/Unity -projectPath Project -batchMode -executeMethod Unity.MLAgents.SampleExporter.ExportCuratedSamples -logFile -

.yamato/com.unity.ml-agents-test.yml

@@ -24,7 +24,7 @@ test_platforms:
       flavor: b1.small
     - name: linux
       type: Unity::VM
-      image: package-ci/ubuntu:stable
+      image: ml-agents/ml-agents-ubuntu-18.04:latest
       flavor: b1.medium
 
 packages:
@@ -123,10 +123,14 @@ test_{{ package.name }}_{{ platform.name }}_trunk:
         image: {{ platform.image }}
         flavor: {{ platform.flavor}}
     commands:
-        - python -m pip install unity-downloader-cli --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple --upgrade
-        - unity-downloader-cli -u trunk -c editor --wait --fast
-        - npm install upm-ci-utils@stable -g --registry https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm
-        - upm-ci project test -u {{ editor.version }} --project-path {{ editor.testProject }} --package-filter {{ package.name }} --extra-create-project-arg="-upmNoDefaultPackages" --extra-utr-arg "reruncount=2"
+        - |
+{% if platform.name == "linux" %}
+          conda activate python3.7
+{% endif %}
+          python -m pip install unity-downloader-cli --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple --upgrade
+          unity-downloader-cli -u trunk -c editor --wait --fast
+          npm install upm-ci-utils@stable -g --registry https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm
+          upm-ci project test -u {{ editor.version }} --project-path {{ editor.testProject }} --package-filter {{ package.name }} --extra-create-project-arg="-upmNoDefaultPackages" --extra-utr-arg "reruncount=2"
     artifacts:
         logs:
             paths:

.yamato/compressed-sensor-test.yml

@@ -5,14 +5,14 @@ test_compressed_obs_{{ editor.version }}:
   name: Test Compressed Sensor Observation {{ editor.version }}
   agent:
     type: Unity::VM
-    image: package-ci/ubuntu:stable
+    image: ml-agents/ml-agents-ubuntu-18.04:latest
     flavor: b1.medium
   variables:
     UNITY_VERSION: {{ editor.version }}
   commands:
     - |
-      sudo apt-get update && sudo apt-get install -y python3-venv
-      python3 -m venv venv && source venv/bin/activate
+      eval "$($HOME/anaconda/bin/conda shell.bash hook)"
+      conda activate python3.7
       python -m pip install pyyaml --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple
       python -u -m ml-agents.tests.yamato.setup_venv
       python ml-agents/tests/yamato/scripts/run_compressed_sensor.py --env=artifacts/testPlayer-TestGridCompressed

.yamato/coverage_tests.metafile

@@ -5,7 +5,7 @@ coverage_test_editors:
 coverage_test_platforms:
     - name: linux
       type: Unity::VM
-      image: package-ci/ubuntu:stable
+      image: ml-agents/ml-agents-ubuntu-18.04:latest
       flavor: b1.medium
 
 coverage_test_packages:

.yamato/gym-interface-test.yml

@@ -5,14 +5,14 @@ test_gym_interface_{{ editor.version }}:
   name: Test Linux Gym Interface {{ editor.version }}
   agent:
     type: Unity::VM
-    image: package-ci/ubuntu:stable
+    image: ml-agents/ml-agents-ubuntu-18.04:latest
     flavor: b1.medium
   variables:
     UNITY_VERSION: {{ editor.version }}
   commands:
     - |
-      sudo apt-get update && sudo apt-get install -y python3-venv
-      python3 -m venv venv && source venv/bin/activate
+      eval "$($HOME/anaconda/bin/conda shell.bash hook)"
+      conda activate python3.7
       python -m pip install wheel --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple
       python -m pip install pyyaml --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple
       python -u -m ml-agents.tests.yamato.setup_venv

.yamato/protobuf-generation-test.yml

@@ -2,15 +2,16 @@ test_linux_protobuf_generation:
   name: Protobuf Generation Tests
   agent:
     type: Unity::VM
-    image: package-ci/ubuntu:stable
+    image: ml-agents/ml-agents-ubuntu-18.04:latest
     flavor: b1.large
   variables:
     GRPC_VERSION: "1.14.1"
     CS_PROTO_PATH: "com.unity.ml-agents/Runtime/Grpc/CommunicatorObjects"
   commands:
     - |
-      sudo apt-get update && sudo apt-get install -y python3-venv nuget
-      python3 -m venv venv && source venv/bin/activate
+      sudo apt-get update && sudo apt-get install -y nuget
+      eval "$($HOME/anaconda/bin/conda shell.bash hook)"
+      conda activate python3.7
       nuget install Grpc.Tools -Version $GRPC_VERSION -OutputDirectory protobuf-definitions/
       python3 -m pip install --upgrade pip --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple
       python3 -m pip install grpcio==1.28.1 grpcio-tools==1.13.0 protobuf==3.11.3 six==1.14.0 mypy-protobuf==1.16.0  --progress-bar=off --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple

.yamato/pytest-gpu.yml

@@ -2,12 +2,12 @@ pytest_gpu:
   name: Pytest GPU
   agent:
     type: Unity::VM::GPU
-    image: package-ci/ubuntu:stable
+    image: ml-agents/ml-agents-ubuntu-18.04:latest
     flavor: b1.large
   commands:
     - |
-      sudo apt-get update && sudo apt-get install -y python3-venv
-      python3 -m venv venv && source venv/bin/activate
+      eval "$($HOME/anaconda/bin/conda shell.bash hook)"
+      conda activate python3.7
       python3 -m pip install pyyaml --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple
       python3 -u -m ml-agents.tests.yamato.setup_venv
       python3 -m pip install --progress-bar=off -r test_requirements.txt --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple

.yamato/python-ll-api-test.yml

@@ -5,14 +5,14 @@ test_linux_ll_api_{{ editor.version }}:
   name: Test Linux LL-API {{ editor.version }}
   agent:
     type: Unity::VM
-    image: package-ci/ubuntu:stable
+    image: ml-agents/ml-agents-ubuntu-18.04:latest
     flavor: b1.medium
   variables:
     UNITY_VERSION: {{ editor.version }}
   commands:
     - |
-      sudo apt-get update && sudo apt-get install -y python3-venv
-      python3 -m venv venv && source venv/bin/activate
+      eval "$($HOME/anaconda/bin/conda shell.bash hook)"
+      conda activate python3.7
       python -m pip install pyyaml --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple
       python -u -m ml-agents.tests.yamato.setup_venv
       python ml-agents/tests/yamato/scripts/run_llapi.py

.yamato/standalone-build-test.yml

@@ -5,20 +5,23 @@ test_linux_standalone_{{ editor.version }}:
   name: Test Linux Standalone {{ editor.version }}
   agent:
     type: Unity::VM
-    image: package-ci/ubuntu:stable
+    image: ml-agents/ml-agents-ubuntu-18.04:latest
     flavor: b1.large
   variables:
     UNITY_VERSION: {{ editor.version }}
   commands:
-    - python3 -m pip install pyyaml --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple
-    - python3 -m pip install unity-downloader-cli --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple --upgrade
-    - unity-downloader-cli -u {{ editor.version }} -c editor --wait --fast
-    - python3 -u -m ml-agents.tests.yamato.standalone_build_tests --build-target=linux
-    - python3 -u -m ml-agents.tests.yamato.standalone_build_tests --build-target=linux --scene=Assets/ML-Agents/Examples/Basic/Scenes/Basic.unity
-    - python3 -u -m ml-agents.tests.yamato.standalone_build_tests --build-target=linux --scene=Assets/ML-Agents/Examples/Match3/Scenes/Match3.unity
-    - python3 -u -m ml-agents.tests.yamato.standalone_build_tests --build-target=linux --scene=Assets/ML-Agents/Examples/WallJump/Scenes/WallJump.unity
-    - python3 -u -m ml-agents.tests.yamato.standalone_build_tests --build-target=linux --scene=Assets/ML-Agents/TestScenes/TestCompressedGrid/TestGridCompressed.unity
-    - python3 -u -m ml-agents.tests.yamato.standalone_build_tests --build-target=linux --scene=Assets/ML-Agents/TestScenes/TestCompressedTexture/TestTextureCompressed.unity
+    - |
+      eval "$($HOME/anaconda/bin/conda shell.bash hook)"
+      conda activate python3.7
+      python3 -m pip install pyyaml --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple
+      python3 -m pip install unity-downloader-cli --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple --upgrade
+      unity-downloader-cli -u {{ editor.version }} -c editor --wait --fast
+      python3 -u -m ml-agents.tests.yamato.standalone_build_tests --build-target=linux
+      python3 -u -m ml-agents.tests.yamato.standalone_build_tests --build-target=linux --scene=Assets/ML-Agents/Examples/Basic/Scenes/Basic.unity
+      python3 -u -m ml-agents.tests.yamato.standalone_build_tests --build-target=linux --scene=Assets/ML-Agents/Examples/Match3/Scenes/Match3.unity
+      python3 -u -m ml-agents.tests.yamato.standalone_build_tests --build-target=linux --scene=Assets/ML-Agents/Examples/WallJump/Scenes/WallJump.unity
+      python3 -u -m ml-agents.tests.yamato.standalone_build_tests --build-target=linux --scene=Assets/ML-Agents/TestScenes/TestCompressedGrid/TestGridCompressed.unity
+      python3 -u -m ml-agents.tests.yamato.standalone_build_tests --build-target=linux --scene=Assets/ML-Agents/TestScenes/TestCompressedTexture/TestTextureCompressed.unity
   triggers:
     cancel_old_ci: true
     expression: |

.yamato/standalone-build-webgl-test.yml

@@ -3,18 +3,18 @@ test_webgl_standalone_{{ editor_version }}:
   name: Test WebGL Standalone {{ editor_version }}
   agent:
     type: Unity::VM
-    image: package-ci/ubuntu:stable
+    image: ml-agents/ml-agents-ubuntu-18.04:latest
     flavor: b1.large
   variables:
     UNITY_VERSION: {{ editor_version }}
   commands:
     - |
-      python3 -m venv venv && source venv/bin/activate
+      eval "$($HOME/anaconda/bin/conda shell.bash hook)"
+      conda activate python3.7
       python -m pip install pyyaml --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple
       python -m pip install unity-downloader-cli --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple --upgrade
       unity-downloader-cli -u {{ editor_version }} -c editor -c WebGL --wait --fast
       python -u -m ml-agents.tests.yamato.standalone_build_tests --build-target=webgl
-
   triggers:
     cancel_old_ci: true
     recurring:

.yamato/training-int-tests.yml

@@ -5,14 +5,14 @@ test_linux_training_int_{{ editor.version }}:
   name: Test Linux Fast Training {{ editor.version }}
   agent:
     type: Unity::VM
-    image: package-ci/ubuntu:stable
+    image: ml-agents/ml-agents-ubuntu-18.04:latest
     flavor: b1.medium
   variables:
     UNITY_VERSION: {{ editor.version }}
   commands:
     - |
-      sudo apt-get update && sudo apt-get install -y python3-venv
-      python3 -m venv venv && source venv/bin/activate
+      eval "$($HOME/anaconda/bin/conda shell.bash hook)"
+      conda activate python3.7
       python -m pip install pyyaml --index-url https://artifactory.prd.it.unity3d.com/artifactory/api/pypi/pypi/simple
       python -u -m ml-agents.tests.yamato.training_int_tests
   dependencies:

com.unity.ml-agents/CHANGELOG.md

@@ -10,6 +10,8 @@ and this project adheres to
 ### Major Changes
 #### com.unity.ml-agents / com.unity.ml-agents.extensions (C#)
 #### ml-agents / ml-agents-envs / gym-unity (Python)
+- The minimum supported Python version for ml-agents-envs was changed to 3.7.2 (#4)
+
 ### Minor Changes
 #### com.unity.ml-agents / com.unity.ml-agents.extensions (C#)
 #### ml-agents / ml-agents-envs / gym-unity (Python)

docs/Installation-Anaconda-Windows.md

@@ -18,8 +18,8 @@ versions and features.
 
 [Download](https://www.anaconda.com/download/#windows) and install Anaconda for
 Windows. By using Anaconda, you can manage separate environments for different
-distributions of Python. Python 3.6.1 or higher is required as we no longer
-support Python 2. In this guide, we are using Python version 3.6 and Anaconda
+distributions of Python. Python 3.7.2 or higher is required as we no longer
+support Python 2. In this guide, we are using Python version 3.7 and Anaconda
 version 5.1
 ([64-bit](https://repo.continuum.io/archive/Anaconda3-5.1.0-Windows-x86_64.exe)
 or [32-bit](https://repo.continuum.io/archive/Anaconda3-5.1.0-Windows-x86.exe)
@@ -80,12 +80,12 @@ To create a new Conda environment, open a new Anaconda Prompt (_Anaconda Prompt_
 in the search bar) and type in the following command:
 
 ```sh
-conda create -n ml-agents python=3.6
+conda create -n ml-agents python=3.7
 ```
 
 You may be asked to install new packages. Type `y` and press enter _(make sure
 you are connected to the Internet)_. You must install these required packages.
-The new Conda environment is called ml-agents and uses Python version 3.6.
+The new Conda environment is called ml-agents and uses Python version 3.7.
 
 <p align="center">
   <img src="images/conda_new.PNG" alt="Anaconda Install" width="500" border="10" />

docs/Installation.md

@@ -27,7 +27,7 @@ The ML-Agents Toolkit contains several components:
 Consequently, to install and use the ML-Agents Toolkit you will need to:
 
 - Install Unity (2020.3 or later)
-- Install Python (3.6.1 or higher)
+- Install Python (3.7.2 or higher)
 - Clone this repository (Optional)
   - __Note:__ If you do not clone the repository, then you will not be
   able to access the example environments and training configurations or the
@@ -44,9 +44,9 @@ Consequently, to install and use the ML-Agents Toolkit you will need to:
 strongly recommend that you install Unity through the Unity Hub as it will
 enable you to manage multiple Unity versions.
 
-### Install **Python 3.6.1** or Higher
+### Install **Python 3.7.2** or Higher
 
-We recommend [installing](https://www.python.org/downloads/) Python 3.6 or 3.7.
+We recommend [installing](https://www.python.org/downloads/) Python 3.7.
 If you are using Windows, please install the x86-64 version and not x86.
 If your Python environment doesn't include `pip3`, see these
 [instructions](https://packaging.python.org/guides/installing-using-linux-tools/#installing-pip-setuptools-wheel-with-linux-package-managers)

docs/Using-Virtual-Environment.md

@@ -19,7 +19,7 @@ from dependencies of other projects. This has a few advantages:
 
 ## Python Version Requirement (Required)
 
-This guide has been tested with Python 3.6 through Python 3.8. Newer versions might not
+This guide has been tested with Python 3.7 through Python 3.8. Newer versions might not
 have support for the dependent libraries, so are not recommended.
 
 ## Installing Pip (Required)
@@ -65,7 +65,7 @@ then python3-distutils needs to be installed. Install python3-distutils using
 
 Note:
 
-- Verify that you are using Python 3.6 or Python 3.7. Launch a command prompt
+- Verify that you are using Python 3.7. Launch a command prompt
   using `cmd` and execute `python --version` to verify the version.
 - Python3 installation may require admin privileges on Windows.
 - This guide is for Windows 10 using a 64-bit architecture only.